Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content locations using Windows UNC paths are inaccessible #38

Closed
echo6ix opened this issue Mar 28, 2019 · 1 comment · Fixed by #91
Closed

Content locations using Windows UNC paths are inaccessible #38

echo6ix opened this issue Mar 28, 2019 · 1 comment · Fixed by #91
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@echo6ix
Copy link
Contributor

echo6ix commented Mar 28, 2019

Just documenting this issue per our discussion on Discord.

I spent an hour or so looking into UNC paths, kind of hit a wall. The first problem was the fact that the library I'm using for globbing (doublestar) doesn't seem to support UNC paths. I tried removing that and writing the logic myself, but for some reason I'm unable to access any of the folders within the share. I can see the share itself and its contents, but none of the folders inside the share. I get an error saying The system cannot find the path specified. even though it's there and I can access it.

Content locations using Windows UNC paths, //servername/folder, are inaccessible to the app.

Windows users will have to map network locations to a drive either using the file explorer or command line method until the issue is resolved .

@StashAppDev StashAppDev added bug Something isn't working help wanted Extra attention is needed labels Mar 28, 2019
@WithoutPants
Copy link
Collaborator

I've sent a PR for doublestar to support UNC paths. I can put in a PR to update the vendor copy if wanted, or can wait to see if the PR is accepted and update the local copy then.

With the fix, I was able to scan and access videos over network share without any issue.

WithoutPants added a commit to WithoutPants/stash that referenced this issue Aug 2, 2019
StashAppDev added a commit that referenced this issue Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants