Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add and display studio without image #58

Closed
echo6ix opened this issue May 28, 2019 · 3 comments
Closed

[Request] Add and display studio without image #58

echo6ix opened this issue May 28, 2019 · 3 comments
Milestone

Comments

@echo6ix
Copy link
Contributor

echo6ix commented May 28, 2019

Please consider adding the following:

  1. Ability to create new studio without an image. Studios that do not have an image should just appear as a text link.
  2. A toggle override in the settings to display the text studio name everywhere instead of the studio image

What's the use-case for this other than preferring text over a logo? A lot of studios don't have a logo or image representation, such as very small clips 4 sale "studios".

@StashAppDev
Copy link
Member

Images are required due to how I handle the JSON export. I needed some type of unique identifier for the studio json filenames which could be mapped back to the studio name string. The identifier I use is the MD5 hash of the image.

For example:

  • Studio A has an image which hashes to 30bcf62db486d0248f5566833074fed3.
  • The metadata exports to studios/30bcf62db486d0248f5566833074fed3.json
  • in mappings.json under the studios map I map "Studio A" to 30bcf62db486d0248f5566833074fed3. Allowing me to map the correct studio file to the given studio name

This probably isn't ideal, but I haven't had time to circle back and rethink the JSON schema and how this might work.

@echo6ix
Copy link
Contributor Author

echo6ix commented Jun 18, 2019

Thanks for taking your time to explain how it works.

I don't understand why the identifier cannot be from the MD5 hash of a string value, such as the Studio Name, but I'm sure there's a good reason.

@Leopere
Copy link
Collaborator

Leopere commented Nov 4, 2019

Closed by #109

@Leopere Leopere closed this as completed Nov 4, 2019
@WithoutPants WithoutPants added this to the Version 0.1.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants