Generate performer checksum from name instead of image. Use default performer image #109
Conversation
|
Added the same change for studios (I was going to make a separate PR, but it required the same utils method). Added a placeholder studio image as well. Resolves #58
|
As discussed on Discord, it might be a good idea to create an option in I'm not sure if providing a Studio Name is mandatory when creating a studio. If not it might be a good idea to make it mandatory to avoid outputing a null string if they turn off studio images on the scene pages. |
|
@WithoutPants Better wait for Stash to tell you in detail though |
|
Is this PR a WIP? If it is please add WIP into the PR name so its not possible to merge until you remove it. |
It wasn't until @bnkai 's find. Fixed up the issues found. |
It shouldn't really matter if it is inconsistent for existing data. You could indeed correct it with an export and re-import, but otherwise the app is going to function the same regardless, and the checksum is only exposed to the user during the export/import anyway. |
|
Yo folks. I started making a NoID performer image for the default .... I then liked the idea and made 40 of them ahah. Attached a zip with all of them. My idea, and it would be awesome if doable, is to have the system pick one at random for each new entry. This would alleviate the repetitiveness that a single picture would create. Let me know :) Preview:
|
|
Nice work!
…On Fri, Aug 23, 2019 at 12:18 PM iKeats ***@***.***> wrote:
Yo folks. I started making a NoID performer image for the default .... I
then liked the idea and made 40 of them ahah. Attached a zip with all of
them. My idea, and it would be awesome if doable, is to have the system
pick one at random for each new entry. This would alleviate the
repetitiveness that a single picture would create. Let me know :)
Preview:
[image: NoName04]
<https://user-images.githubusercontent.com/54415533/63607174-210fd300-c5d2-11e9-98c8-fa8cb1d3a360.png>
NoName.zip <https://github.com/stashapp/stash/files/3535319/NoName.zip>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=AAIE2VVB6Z6JUKKLMOKN2ODQGAEVBA5CNFSM4IOAQQB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AVN5Q#issuecomment-524375798>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VXAGEEYUYVK2BKXUOLQGAEVBANCNFSM4IOAQQBQ>
.
|
…Pants/stash into optional_performer_image
|
Added a packr box with the images @iKeats kindly provided. Changed so that a random image is selected from the images if none is provided. |
WithoutPants
changed the title
WithoutPants
changed the title
|
Merged from master. Ready for retesting. |
|
I really like this PR and i just need to test the import , export ( the other parts were tested ok way back) but given the major change for the checksum should we wait for feedback from stash himself? |
|
Given the lack of feedback i tested this out again. It looks ok |
|
@iKeats you should make these silhouette designs for all of the tags good grief they look fantastic. |
Leopere
added
feature
Resolves #67
Changes the checksum generation for performers to be based on name instead of image. Name should be unique for performers anyway, so it makes sense to generate the checksum on the performer name. This also means an image can be reused (for generic images).
This change also adds a default generic performer image, for when no image is provided. The current image is really just a placeholder, and I'd like a better one. Ideally, the replacement would be similarly compact.