Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Organized flag to scenes #729

Closed
WithoutPants opened this issue Aug 12, 2020 · 2 comments · Fixed by #988
Closed

[Feature] Add Organized flag to scenes #729

WithoutPants opened this issue Aug 12, 2020 · 2 comments · Fixed by #988
Assignees
Labels
feature Pull requests that add a new feature
Milestone

Comments

@WithoutPants
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Users have expressed a desire to exclude scenes from the auto-tagger. It would also be useful information to query on to be able to exclude scenes that are complete from a metadata point of view.

Describe the solution you'd like
Add an "Organized" flag to scenes. Scenes with this flag set to true should be excluded from the auto-tagger and should be excluded by default from the filename parser as well. It should be possible query scenes based on the value of this flag.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Aug 12, 2020
@WithoutPants WithoutPants added this to the Version 0.4.0 milestone Aug 12, 2020
@WithoutPants WithoutPants self-assigned this Aug 12, 2020
@bnkai
Copy link
Collaborator

bnkai commented Aug 13, 2020

I think it was mentioned again in the discord channel and piere-delecto's script already uses this approach, can't we just use some system reserverd tags ? For the specific case if a scene has a say stash_metadata_locked tag applied then no automatic action regarding mutation of metadata should occur ( auto-tagger, list from filename parser ).
If a flag is to be used there should be a filter that makes it easy for the user to find the scenes he flagged.

@WithoutPants
Copy link
Collaborator Author

This approach would work if we really wanted to avoid a schema modification, but in my opinion is a misuse/conflation of the tag concept. A flag is a cleaner approach, has a clearer purpose and doesn't pollute the user's tag collection with a system-only entry.

cc1234475 pushed a commit to cc1234475/stash that referenced this issue Oct 10, 2020
cc1234475 pushed a commit to cc1234475/stash that referenced this issue Oct 11, 2020
@WithoutPants WithoutPants modified the milestones: Backlog, Version 0.5.0 Dec 7, 2020
WithoutPants added a commit that referenced this issue Dec 17, 2020
* Add organized boolean to scene model (#729)
* Add organized button to scene page
* Add flag to galleries and images
* Import/export changes
* Make organized flag not null
* Ignore organized scenes for autotag

Co-authored-by: com1234 <com1234@notarealemail.com>
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this issue Feb 1, 2021
* Add organized boolean to scene model (stashapp#729)
* Add organized button to scene page
* Add flag to galleries and images
* Import/export changes
* Make organized flag not null
* Ignore organized scenes for autotag

Co-authored-by: com1234 <com1234@notarealemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants