True case insensitive regex support #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermieisinthehouse
approved these changes
Feb 14, 2022
bnkai
approved these changes
Feb 15, 2022
WithoutPants
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like regular expressions and filenames both were having strings.ToLower applied to them. There are many special meta-sequences in regex that are upper case and converting them to lower case reverses them. For instance \D means any non-digit character and the current code was converting it to \d meaning any digit.
To fix this I now prepend (?i) to the beginning of any regex that does not have (?i) at the start already. This maintains the case insensitivity while allowing uppercase meta-sequences to be used.
I also added some test cases to ensure the functionality.