-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movie select overhaul #4563
Merged
Merged
Movie select overhaul #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
damontecres
added a commit
to damontecres/StashAppAndroidTV
that referenced
this pull request
Mar 6, 2024
This PR tracks the updates needed to support the future Stash `v0.25.0`. Includes graphql updates for: - [x] stashapp/stash#4419 - [x] stashapp/stash#4532 - [x] stashapp/stash#4479 Deferring updates for: - stashapp/stash#4602 - stashapp/stash#4563 Closes #44
damontecres
added a commit
to damontecres/StashAppAndroidTV
that referenced
this pull request
Mar 10, 2024
stashapp/stash#4563 (added in `v0.25.0`) updated the remaining find queries to use `ID` instead of `Int`. The `ID` type in graphql is serialized as a String, but the server implements them as auto increment integers in the database. This PR updates all of the ID references to Strings for any potential future proofing. Note: This PR does not updated the find queries used by this app to use the ID fields. See deferred list in #132.
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Add ids to findMovies input * Use ids for other find interfaces * Update client side * Fix gallery select function * Replace movie select * Re-add creatable * Overhaul movie table * Remove and deprecated unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last usage of the
All*
graphql interfaces. All of these interfaces are now marked as deprecated.Overhauls the movie select control to be in line with the other object select controls.
Overhauls the scene movie table:
New movies can be added by selecting from the last movie select control. Movies can be deleted by pressing the x in the movie selector.