Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie select overhaul #4563

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Conversation

WithoutPants
Copy link
Collaborator

This removes the last usage of the All* graphql interfaces. All of these interfaces are now marked as deprecated.

Overhauls the movie select control to be in line with the other object select controls.

Overhauls the scene movie table:

image
image

New movies can be added by selecting from the last movie select control. Movies can be deleted by pressing the x in the movie selector.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Feb 15, 2024
@WithoutPants WithoutPants added this to the Version 0.25.0 milestone Feb 15, 2024
@WithoutPants WithoutPants merged commit e231812 into stashapp:develop Feb 18, 2024
2 checks passed
damontecres added a commit to damontecres/StashAppAndroidTV that referenced this pull request Mar 6, 2024
This PR tracks the updates needed to support the future Stash `v0.25.0`.

Includes graphql updates for:
- [x] stashapp/stash#4419
- [x] stashapp/stash#4532
- [x] stashapp/stash#4479

Deferring updates for:
- stashapp/stash#4602
- stashapp/stash#4563

Closes #44
damontecres added a commit to damontecres/StashAppAndroidTV that referenced this pull request Mar 10, 2024
stashapp/stash#4563 (added in `v0.25.0`) updated
the remaining find queries to use `ID` instead of `Int`. The `ID` type
in graphql is serialized as a String, but the server implements them as
auto increment integers in the database.

This PR updates all of the ID references to Strings for any potential
future proofing.

Note: This PR does not updated the find queries used by this app to use
the ID fields. See deferred list in #132.
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Add ids to findMovies input
* Use ids for other find interfaces
* Update client side
* Fix gallery select function
* Replace movie select
* Re-add creatable
* Overhaul movie table
* Remove and deprecated unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant