Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Favoriting #4728

Merged
merged 14 commits into from
May 9, 2024
Merged

Tag Favoriting #4728

merged 14 commits into from
May 9, 2024

Conversation

Dankonite
Copy link
Contributor

added tag favoriting, still needs the filter support
image

@Dankonite
Copy link
Contributor Author

Added the filter getting a wierd error tho and no idea what causes this. Not ready yet
image

@Dankonite
Copy link
Contributor Author

Finally got the filter to work

@WithoutPants
Copy link
Collaborator

Thanks for the PR. Please address the failed checks.

@Dankonite
Copy link
Contributor Author

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

@SpedNSFW
Copy link
Contributor

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

Just look through your changes and undo the pointless ones, like changing indentation. That would be a start. For the others, go to checks and look at the details for why they're failing.

@Dankonite
Copy link
Contributor Author

so I ran yarn validate and some of the stuff that is throwing errors are things I didnt even mess with lmao
image
Do I need to make these changes from a diferent branch or something. I just forked off of develop maybe at a bad time or something

@DogmaDragon
Copy link
Collaborator

Migration version conflicts with existing one https://github.com/stashapp/stash/blob/develop/pkg/sqlite/migrations/56_studio_favorite.up.sql.

You will need to either update the existing migration or bump the version.

@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 9, 2024
@WithoutPants WithoutPants added the feature Pull requests that add a new feature label May 9, 2024
@WithoutPants WithoutPants merged commit 29859fa into stashapp:develop May 9, 2024
2 checks passed
damontecres added a commit to damontecres/StashAppAndroidTV that referenced this pull request Jul 16, 2024
Adds the heart indicator to the overlay for favorite tag and studio
cards.

Requires server `v0.26.0`

Ref:
- stashapp/stash#4675
- stashapp/stash#4728
damontecres added a commit to damontecres/StashAppAndroidTV that referenced this pull request Aug 29, 2024
Adds the heart indicator to the overlay for favorite tag and studio
cards.

Requires server `v0.26.0`

Ref:
- stashapp/stash#4675
- stashapp/stash#4728
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Add missing key unbind
---------
Co-authored-by: WithoutPants <53250216+WithoutPants@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Favourite Tags [Feature] Add favorite implementation to studios and tags
4 participants