Add Chart and documentation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 16, 2019 18:01
hossainemruz
changed the title
6 tasks
hossainemruz
changed the title
tamalsaha
reviewed
Jul 21, 2019
| @@ -44,8 +59,8 @@ BIN_PLATFORMS := $(DOCKER_PLATFORMS) | |||
| OS := $(if $(GOOS),$(GOOS),$(shell go env GOOS)) | |||
| ARCH := $(if $(GOARCH),$(GOARCH),$(shell go env GOARCH)) | |||
|
|
|||
| BASEIMAGE_PROD ?= postgres:9.5-alpine | |||
| BASEIMAGE_DBG ?= postgres:9.5 | |||
| BASEIMAGE_PROD ?= postgres:11.2-alpine | |||
There was a problem hiding this comment.
The first code should be for 9.x version. Let's talk on Monday. @hossainemruz
|
tamalsaha
reviewed
Jul 21, 2019
|
|
||
| - Install Stash in your cluster following the steps [here](https://appscode.com/products/stash/0.8.3/setup/install/). | ||
|
|
||
| - Install [KubeDB](https://kubedb.com) in your cluster following the steps [here](https://kubedb.com/docs/0.12.0/setup/install/). |
There was a problem hiding this comment.
Clarify that it does not have to be provisioned by KubeDB
tamalsaha
reviewed
Jul 21, 2019
| name: pg-backup-{{- .Chart.Version }} | ||
| labels: | ||
| {{- include "postgres-stash.labels" . | nindent 4 }} | ||
| spec: |
tamalsaha
reviewed
Jul 21, 2019
| service: | ||
| name: my-database-service | ||
| port: 5432 | ||
| secret: |
There was a problem hiding this comment.
We need to define the secret format.
tamalsaha
pushed a commit
to stashed/elasticsearch
that referenced
this pull request
Jul 21, 2019
- [x] Fixed Elasticdump - [x] Added chart - [x] added persistence support in chart - [x] Added docs - [x] use `es-restore-6.5` style task name instead of `es-restore-6-5` [wait for changes in stashed/postgres#2 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: