-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent filtering out @ from search queries in Comb #4602
Conversation
Since this causes searches for email addresses to fail; searching for "john@doe.com" would actually search for "johndoe.com".
I wonder why |
I'm not 100% sure; the stripping in the regex is based on "excluding" when stripping. What I mean by that is that the regex is in the format Edit for clarity's sake: you could still totally be right though, I'm not sure myself. |
Sorry, my mistake. I read the diff wrong. I thought you removed an |
Thank you! (For this and for all the recent PRs you've been pumping out) |
No worries, I like the testing you did for the Comb now. I am on a 'small effort issues' crusade 🚒 to try and decrease the issues counter 😄 |
I see that. You're kicking ass. |
Since this causes searches for email addresses to fail; searching for
john@doe.com
would actually search forjohndoe.com
.Fixes #4519