Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Also Use static_cache store for nocache #9527

Merged

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Feb 14, 2024

Following on from #9405 I've noticed that php artisan cache:clear clears the no cache store which goes hand in hand with the static cache URLS. This means you get missing no cache regions after a cache clear.

This PR ensures that the no cache stores use the same static_cache store as the static cache urls, which is cleared only when the static cache is cleared and not when the default cache is cleared.

@jasonvarga jasonvarga merged commit a79ca6d into statamic:4.x Feb 23, 2024
18 checks passed
@ryanmitchell ryanmitchell deleted the fix/use-static-store-for-nocache branch February 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants