Make AssetQueryBuilder for performance gains #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvesterDamgaard
suggested changes
Nov 17, 2023
|
I can confirm the migration is now working as expected. |
ryanmitchell
added a commit
that referenced
this pull request
Nov 29, 2023
This reverts commit bf039e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings an AssetQueryBuilder to eloquent driver, reducing the number of file systems calls made and removing the need for a stache cache of the path listing.
This is particularly useful for sites with a large number of assets in cloud storage, as asides from initially populating a folder cache and accessing assets individually, all queries, filtering and meta will be only accessed from the database.
Replaces #207
Closes #191