added RestartAfterListenError #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use server.ListenerSocket. RestartAfterListenError to automatically restart the listener after it closes because of an error
| @@ -15,6 +15,7 @@ public interface ISocket | |||
| int RemotePort { get; } | |||
| Stream Stream { get; } | |||
| bool NoDelay { get; set; } | |||
| bool RestartAfterListenError { get; set; } | |||
There was a problem hiding this comment.
Because this property is only used by WebSocketServer, I would put it on that class.
moved RestartAfterListenError to the WebSocketServer class
|
@statianzo yeah that makes more sense. This should be better. Let me know what you think? |
|
ahhh, I just did the same thing. :-) either works, but yours does show two files changed. @statianzo what do you think about adding this to the readme as well? |
|
Add it to the readme and it looks good to merge. 👍 |
|
@artfulhacker my text editor removes spaces on empty lines. I modified that file and then reverted the changes but the empty lines still got removed, that's why mine shows two files changed. |
|
I'm trying to switch to IPv6 but ran into an issue related to this #185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use server.ListenerSocket. RestartAfterListenError to automatically
restart the listener after it closes because of an error