Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CssNext Replacement #26

Merged
merged 3 commits into from
Jun 20, 2017
Merged

CssNext Replacement #26

merged 3 commits into from
Jun 20, 2017

Conversation

jescalan
Copy link
Member

Cssnext is currently severely bugged, and generally not as well maintained as we'd like, so we're replacing it with a list of individual plugins from it, which include the vast majority of its functionality.

@coveralls
Copy link

Coverage Status

Coverage decreased (-86.8%) to 13.158% when pulling 7a04ca7 on replace-cssnext into 240464c on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-86.8%) to 13.158% when pulling daa6be5 on replace-cssnext into 240464c on master.

@calebeby
Copy link
Contributor

Yeah, I think this is a good change.

@jescalan
Copy link
Member Author

You mean other than the 86% coverage decrease? 🧌

@calebeby
Copy link
Contributor

Yeah...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1f9840b on replace-cssnext into 240464c on master.

@dbox
Copy link

dbox commented Jun 20, 2017

👏 🙇

@jescalan jescalan merged commit 570cd1e into master Jun 20, 2017
@jescalan jescalan deleted the replace-cssnext branch June 20, 2017 15:49
@01ivr3
Copy link

01ivr3 commented Dec 17, 2017

Do I have this correct, you guys decided to break apart cssnext and and only load a subset of it's functionality in the default spike-css-standards plugin pack? If so, should this be reflected in Spike's CSS Standards documentation to clearly indicate which features of cssnext are currently included and which are not?

Edit: or at least indicate only a subset is included and reference the plugin packs git repository to warn users they'll need to keep track of which features are missing?

@jescalan
Copy link
Member Author

Yep, exactly. cssnext was having some issues, and we took a bit more of an active approach to maintenance. Good catch though, I'll update this in the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants