You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
AutofillSugar prices a Batch the way rippled's Batch::calculateBaseFeeImpl does (#316): one base fee for batch processing, one for the outer transaction, each inner transaction through its own per-type rule (EscrowFinish with Fulfillment, the reserve-fee types, LoanSet, LoanPay, confidential MPT, sponsor multisig signers), and one base fee per BatchSigners signature. Signatures already present are counted as rippled counts them (one per TxnSignature, one per nested Signers entry); each required account from GetBatchSignerAccounts that has not signed yet counts as one. It charged 3 base fees plus one base fee (or the reserve fee) per inner, which underpriced an EscrowFinish with a fulfillment and any batch with more than one co-signer. An inner Batch or an inner without TransactionType raises ValidationException. BATCH_BASE_FEE_MULTIPLIER is removed. A participant that multi-signs its BatchSigner still needs a Fee set by hand
XrplWallet.SignAsBatchPart builds the batch preimage with the ticket number when the outer Batch has Sequence 0 (or none) and a TicketSequence, as rippled's STTx::getSeqProxy().value() does (#316); it used 0, so every BatchSigners signature for a ticketed outer failed with Invalid signature. The serialized Sequence stays 0. A Sequence or TicketSequence that is not a UInt32 raises ValidationException
Tests: TestUAutofillFees adds an inner EscrowFinish with a fulfillment, present single and multi-signed BatchSigners plus a missing one, and a nested Batch; the two existing Batch cases expect the BatchSigners fee. TestUBatchSigningV11.TestUSignAsBatchPart_TicketSequence_SerializesSequenceZero expects the ticket number in the preimage, and TestUSignAsBatchPart_SequenceZeroAndTicket_SignsOverTicketNumber is added. TestIBatch.TestBatchMultiAccounts_OuterOnTicket submits a co-signed batch on a ticketed outer, and TestBatchIndependent_EscrowFinishWithFulfillment_AutofilledFeeSuffices finishes 8 escrows with fulfillments in one tfIndependent batch at the autofilled fee