This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Compatibility fixes #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wating for this merge 👍 👍 thanks! |
|
would really like this to be merged! |
|
+1 |
|
I very recently merged a PR that enabled the subdomain wildcard (#2). Can you explain what the proper fix for fetching subdomain wildcards would be? |
|
According to the certbot docs, the DNS challenge is the only way to get wildcards certificates. Please see the table few paragraphs below the beginning of the section: Therefore I do not think that there is an automated solution for wildcard certificates at this moment. |
|
Perfect. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes that were needed to make this project running:
Fix the loop when iterating over domains. They need to be separated by space, not coma. Otherwise, this requests one certificate with all domain names glued together instead of a few individual certificates.
Remove the wildcard before the domain name. That is no longer supported with HTTP challenge.