bind to any address for listening (#20)

status-im · Mar 19, 2019 · a69e52b · a69e52b
1 parent 9146e8e
commit a69e52b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/eth/p2p.nim b/eth/p2p.nim
@@ -83,7 +83,8 @@ proc listeningAddress*(node: EthereumNode): ENode =
   return initENode(node.keys.pubKey, node.address)
 
 proc startListening*(node: EthereumNode) =
-  let ta = initTAddress(node.address.ip, node.address.tcpPort)
+  # TODO allow binding to specific IP / IPv6 / etc
+  let ta = initTAddress(IPv4_any(), node.address.tcpPort)
   if node.listeningServer == nil:
     node.listeningServer = createStreamServer(ta, processIncoming,
                                               {ReuseAddr},

diff --git a/eth/p2p/discovery.nim b/eth/p2p/discovery.nim
@@ -257,7 +257,8 @@ proc processClient(transp: DatagramTransport,
     debug "Receive failed", err = getCurrentExceptionMsg()
 
 proc open*(d: DiscoveryProtocol) =
-  let ta = initTAddress(d.address.ip, d.address.udpPort)
+  # TODO allow binding to specific IP / IPv6 / etc
+  let ta = initTAddress(IPv4_any(), d.address.udpPort)
   d.transp = newDatagramTransport(processClient, udata = d, local = ta)
 
 proc lookupRandom*(d: DiscoveryProtocol): Future[seq[Node]] {.inline.} =

diff --git a/eth/p2p/private/p2p_types.nim b/eth/p2p/private/p2p_types.nim
@@ -14,7 +14,7 @@ type
     clientId*: string
     connectionState*: ConnectionState
     keys*: KeyPair
-    address*: Address
+    address*: Address # The external address that the node will be advertising
     peerPool*: PeerPool
 
     # Private fields: