Don't use destructors

status-im · Apr 22, 2020 · caab5c9 · caab5c9
1 parent f3d1c88
commit caab5c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/faststreams/input_stream.nim b/faststreams/input_stream.nim
@@ -65,6 +65,11 @@ proc close*(s: InputStream) {.raises: [IOError, Defect].} =
 
     s.preventFurtherReading()
 
+# TODO
+# The destructors are currently disabled because they seem to cause
+# mysterious segmentation faults related to corrupted GC internal
+# data structures.
+#[
 proc `=destroy`*(h: var InputStreamHandle) {.raises: [Defect].} =
   if h.s != nil:
     if h.s.vtable != nil and h.s.vtable.closeSync != nil:
@@ -82,6 +87,7 @@ proc `=destroy`*(h: var InputStreamHandle) {.raises: [Defect].} =
     # We work-around the problem through more indirect incapacitatation
     # of the stream object:
     h.s.preventFurtherReading()
+]#
 
 converter implicitDeref*(h: InputStreamHandle): InputStream =
   h.s

diff --git a/faststreams/output_stream.nim b/faststreams/output_stream.nim
@@ -72,6 +72,11 @@ proc close*(s: OutputStream) {.raises: [IOError, Defect].} =
     if s.vtable != nil and s.vtable.closeSync != nil:
       s.vtable.closeSync(s)
 
+# TODO
+# The destructors are currently disabled because they seem to cause
+# mysterious segmentation faults related to corrupted GC internal
+# data structures.
+#[
 proc `=destroy`*(h: var OutputStreamHandle) {.raises: [Defect].} =
   if h.s != nil:
     if h.s.vtable != nil and h.s.vtable.closeSync != nil:
@@ -83,6 +88,7 @@ proc `=destroy`*(h: var OutputStreamHandle) {.raises: [Defect].} =
         # `close` manually.
         discard # TODO
     # h.s = nil
+]#
 
 converter implicitDeref*(h: OutputStreamHandle): OutputStream =
   h.s