fix input object value coercion bug, fixes #49

This commit fixes input object value coercion,
a crash in validator, or to be precise in `nullableType`
of `ast.nim`. This commit also fixes empty input object parser
in `common_parser.nim`

graphql/common/ast.nim

@@ -337,7 +337,7 @@ proc nullableType*(node: Node): bool =
     case node[0].kind
     of nkListType:
       return true
-    of nkSym:
+    of nkSym, nkNamedType:
       return false
     else:
       unreachable()

graphql/common_parser.nim

@@ -395,7 +395,8 @@ proc objectField(q: var Parser, isConst: bool, field: var Node) =
 proc objectVal(q: var Parser, isConst: bool, input: var Node) =
   expect tokLCurly
   input = newNode(nkInput)
-  if pfJsonCompatibility in q.flags and currToken == tokRCurly:
+  if currToken == tokRCurly:
+    # input object value can have empty fields
     nextToken()
     return
   repeatUntil(q.conf.maxFields, tokRCurly):

tests/execution/engine.toml

@@ -650,18 +650,102 @@ fragment bird on Bird {
 }
 """
   result = """
- {
-   "creatures":[
-     {
-       "__typename":"Tree",
-       "name":"redwood",
-       "age":100
-     },
-     {
-        "__typename":"Bird",
-        "name":"parrot",
-        "color":"RED"
-     }
-   ]
- }
+{
+  "creatures":[
+    {
+      "__typename":"Tree",
+      "name":"redwood",
+      "age":100
+    },
+    {
+       "__typename":"Bird",
+       "name":"parrot",
+       "color":"RED"
+    }
+  ]
+}
+"""
+
+[[units]]
+  name = "graphql-spec#793 case #1"
+  opName = "A"
+  code = """
+type Query {
+  example(inputObject: ExampleInputObject! = {}): Int
+}
+
+input ExampleInputObject {
+  number: Int! = 3
+}
+query A {
+  example
+}
+"""
+  result = """
+{
+  "example":3
+}
+"""
+
+[[units]]
+  name = "graphql-spec#793 case #2"
+  opName = "B"
+  code = """
+type Query {
+  example(inputObject: ExampleInputObject! = {}): Int
+}
+
+input ExampleInputObject {
+  number: Int! = 3
+}
+query B {
+  example(inputObject: {})
+}
+"""
+  result = """
+{
+  "example":3
+}
+"""
+
+[[units]]
+  name = "graphql-spec#793 case #3"
+  opName = "C"
+  code = """
+type Query {
+  example(inputObject: ExampleInputObject! = {}): Int
+}
+
+input ExampleInputObject {
+  number: Int! = 3
+}
+query C {
+  example(inputObject: { number: 3 })
+}
+"""
+  result = """
+{
+  "example":3
+}
+"""
+
+[[units]]
+  name = "graphql-spec#793 case #4"
+  opName = "D"
+  code = """
+type Query {
+  example(inputObject: ExampleInputObject! = {}): Int
+}
+
+input ExampleInputObject {
+  number: Int! = 3
+}
+query D($inputObject: ExampleInputObject! = {}) {
+  example(inputObject: $inputObject)
+}
+"""
+  result = """
+{
+  "example":3
+}
 """

tests/test_utils.nim

@@ -81,6 +81,11 @@ proc querySearchImpl(ud: RootRef, params: Args, parent: Node): RespResult {.apiP
   list.add respMap(tc.names[tnStarship])
   ok(list)
 
+proc queryExampleImpl(ud: RootRef, params: Args, parent: Node): RespResult {.apiPragma.} =
+  let obj = params[0].val
+  let number = obj[0][1]
+  ok(number)
+
 const queryProtos = {
   "name": queryNameImpl,
   "color": queryColorImpl,
@@ -89,7 +94,8 @@ const queryProtos = {
   "echoArg": queryEchoArgImpl,
   "checkFruit": queryCheckFruit,
   "creatures": queryCreatures,
-  "search": querySearchImpl
+  "search": querySearchImpl,
+  "example": queryExampleImpl
 }
 
 proc creatureNameImpl(ud: RootRef, params: Args, parent: Node): RespResult {.apiPragma.} =