-
Notifications
You must be signed in to change notification settings - Fork 146
bump nimbus-eth2
and fix commithash + copyright banner
#3670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kdeme Can you look at the portal tests ? |
is due to: Because nimbus-eth1/portal/tests/beacon_network_tests/test_beacon_content.nim Lines 190 to 201 in 1ed6871
That change is intentional, and while it's of course technically possible to revert it, maintaining the design it's based on into new forks doesn't make sense. I already haven't for Gloas. nimbus-eth1/portal/tests/beacon_network_tests/test_beacon_content.nim Lines 30 to 45 in 1ed6871
forkDigests is really that unimportant, the configuration information provided to ForkDigests.init can be done on the basis of convenience as well, e.g., something like ForkDigests.init(getMetadataForNetwork("mainnet"), default(Hash32)) should work fine.
|
Then the fix is easy |
Full fix for #3661