Skip to content

Commit e34f69a

Browse files
committed
refactor(conf): remove unused code, change builderProposalDelayTolerance type from int to uint16
1 parent b6672a9 commit e34f69a

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

beacon_chain/conf.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ type
686686
builderProposalDelayTolerance* {.
687687
desc: "Timeout for builder proposal delay tolerance in milliseconds"
688688
defaultValue: 1500
689-
name: "builder-proposal-delay-tolerance" .}: int
689+
name: "builder-proposal-delay-tolerance" .}: uint16
690690

691691
historyMode* {.
692692
desc: "Retention strategy for historical data (archive/prune)"

beacon_chain/spec/mev/electra_mev.nim

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
{.push raises: [].}
99

1010
import ".."/datatypes/[altair, bellatrix, electra]
11-
# import ../../conf
1211

1312
from stew/byteutils import to0xHex
1413
from ".."/datatypes/phase0 import AttesterSlashing
@@ -100,7 +99,6 @@ const
10099

101100
# Spec is 1 second, but mev-boost indirection can induce delay when the relay
102101
# itself has already consumed the entire second.
103-
# BUILDER_PROPOSAL_DELAY_TOLERANCE* = builderProposalDelayTolerance.milliseconds
104102

105103
func shortLog*(v: BlindedBeaconBlock): auto =
106104
(

beacon_chain/validators/beacon_validators.nim

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -996,9 +996,7 @@ proc collectBids(
996996
engineBlockFut = makeBeaconBlockForHeadAndSlot(
997997
EPS, node, randao, validator_index, graffitiBytes, head, slot)
998998

999-
# getBuilderBid times out after BUILDER_PROPOSAL_DELAY_TOLERANCE, with 1 more
1000-
# second for remote validators. makeBeaconBlockForHeadAndSlot times out after
1001-
# 1 second.
999+
10021000
await allFutures(payloadBuilderBidFut, engineBlockFut)
10031001
doAssert payloadBuilderBidFut.finished and engineBlockFut.finished
10041002

0 commit comments

Comments
 (0)