Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate /eth2/beacon_chain/req/beacon_blocks_by_{range,root}/1/ #4207

Closed
wants to merge 5 commits into from

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Oct 3, 2022

For when ethereum/consensus-specs#3014 is merged

This could wait until an actual consensus spec release, but doesn't have to, because as noted:

There haven't been any phase0 blocks in mainnet or any of the still-supported testnets in MIN_EPOCHS_FOR_BLOCK_REQUESTS regardless, so the spec already technically supports not serving said blocks.

So it can be merged as soon as that spec PR is merged.

@tersec tersec marked this pull request as draft October 3, 2022 10:26
Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still do the rate limiting?

     peer.updateRequestQuota(blockByRangeLookupCost)
     peer.awaitNonNegativeRequestQuota()

@tersec
Copy link
Contributor Author

tersec commented Oct 3, 2022

Should we still do the rate limiting?

     peer.updateRequestQuota(blockByRangeLookupCost)
     peer.awaitNonNegativeRequestQuota()

Sure, why not: f1960c8

Discourages use of it, since it's not entirely free.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results

0 files   -          9  0 suites   - 873   0s ⏱️ - 25m 52s
0 tests  -   2 704  0 ✔️  -   2 511  0 💤  - 193  0 ±0 
0 runs   - 11 783  0 ✔️  - 11 564  0 💤  - 219  0 ±0 

Results for commit f71d376. ± Comparison against base commit 9572bb8.

♻️ This comment has been updated with latest results.

@tersec tersec marked this pull request as ready for review November 29, 2022 22:20
@tersec
Copy link
Contributor Author

tersec commented Nov 29, 2022

ethereum/consensus-specs#3014 was merged

@tersec
Copy link
Contributor Author

tersec commented Nov 30, 2022

#4378

@tersec tersec closed this Nov 30, 2022
@tersec tersec deleted the ttR branch November 30, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants