Ensure owner is removed from community when leaving community #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
0x-r4bbit
commented
Nov 12, 2021
protocol/communities/manager.go
Outdated
| @@ -726,8 +726,10 @@ func (m *Manager) LeaveCommunity(id types.HexBytes) (*Community, error) { | |||
| if community == nil { | |||
| return nil, ErrOrgNotFound | |||
| } | |||
| community.RemoveUserFromOrg(m.identity) | |||
There was a problem hiding this comment.
Notice that I'm not handling possible errors here. When this API is called we know that the user exists in the org so removal should always go fine.
There was a problem hiding this comment.
nit: github shows some indentation issue
Jenkins BuildsClick to see older builds (9)
|
0x-r4bbit
added a commit
to status-im/status-desktop
that referenced
this pull request
Nov 12, 2021
…ommunity When an owner of a community leaves its own community, we optimistically update the members list in Status Desktop. The `LeaveCommunity` API that is called via status-lib has been updated to correctly remove that member as well. This depends on status-im/status-go#2429 Fixes #4074
alaibe
approved these changes
Nov 12, 2021
protocol/communities/manager.go
Outdated
| @@ -726,8 +726,10 @@ func (m *Manager) LeaveCommunity(id types.HexBytes) (*Community, error) { | |||
| if community == nil { | |||
| return nil, ErrOrgNotFound | |||
| } | |||
| community.RemoveUserFromOrg(m.identity) | |||
There was a problem hiding this comment.
nit: github shows some indentation issue
0x-r4bbit
force-pushed
the
fix/leave-community
branch
3 times, most recently
from
3424e5c to
44f6685
Compare
Prior to this commit, when a community owner leaves her community, status-go would just set the `joined` flag to `false` without updating the members list. This results in wrong data as the number of members doesn't match the reality. This commit removes the owner of the community from the members list when she's leaving the community.
0x-r4bbit
force-pushed
the
fix/leave-community
branch
from
44f6685 to
f3c0731
Compare
cammellos
approved these changes
Nov 16, 2021
0x-r4bbit
added a commit
to status-im/status-desktop
that referenced
this pull request
Nov 18, 2021
…ommunity When an owner of a community leaves its own community, we optimistically update the members list in Status Desktop. The `LeaveCommunity` API that is called via status-lib has been updated to correctly remove that member as well. This depends on status-im/status-go#2429 Fixes #4074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when a community owner leaves her community,
status-go would just set the
joinedflag tofalsewithout updating themembers list. This results in wrong data as the number of members doesn't
match the reality.
This commit removes the owner of the community from the members list
when she's leaving the community.