WIP Add animation to numpad and button component #10131

Ferossgp · 2020-03-05T08:31:49Z

No description provided.

dependency-lockfile-snitch · 2020-03-05T08:31:53Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

status-github-bot · 2020-03-05T08:31:55Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

status-im-auto · 2020-03-05T08:37:33Z

Jenkins Builds

Click to see older builds (32)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`0c02eab`	#1	2020-03-05 08:37:32	~5 min	`android`	📄`log`
❌	`0c02eab`	#1	2020-03-05 08:42:17	~10 min	`android-e2e`	📄`log`

✔️	`d536a92`	#2	2020-03-05 09:16:51	~12 min	`android-e2e`	📦`apk` 📲
✔️	`d536a92`	#2	2020-03-05 09:22:47	~18 min	`android`	📦`apk` 📲
✔️	`d536a92`	#2	2020-03-05 10:11:50	~10 min	`ios`	📦`ipa` 📲

✔️	`418da35`	#3	2020-03-06 14:44:20	~10 min	`ios`	📦`ipa` 📲
✔️	`418da35`	#3	2020-03-06 14:46:30	~13 min	`android`	📦`apk` 📲
✔️	`418da35`	#3	2020-03-06 14:50:08	~16 min	`android-e2e`	📦`apk` 📲

❌	`88bdefc`	#4	2020-03-09 09:19:28	~20 sec	`android`	📄`log`
❌	`88bdefc`	#4	2020-03-09 09:19:28	~22 sec	`android-e2e`	📄`log`
❌	`88bdefc`	#4	2020-03-09 09:19:30	~20 sec	`ios`	📄`log`

❌	`d7f1190`	#5	2020-03-09 10:53:06	~19 sec	`android-e2e`	📄`log`
❌	`d7f1190`	#5	2020-03-09 10:53:06	~17 sec	`android`	📄`log`
❌	`d7f1190`	#5	2020-03-09 10:53:07	~16 sec	`ios`	📄`log`

❌	`cd2c489`	#6	2020-03-09 11:10:01	~3 min	`android`	📄`log`
❌	`cd2c489`	#6	2020-03-09 11:10:47	~3 min	`android-e2e`	📄`log`
✔️	`cd2c489`	#6	2020-03-09 11:17:37	~10 min	`ios`	📦`ipa` 📲

✔️	`0d12fc2`	#7	2020-03-09 11:44:46	~9 min	`ios`	📦`ipa` 📲
✔️	`0d12fc2`	#7	2020-03-09 11:47:08	~11 min	`android-e2e`	📦`apk` 📲
✔️	`0d12fc2`	#7	2020-03-09 11:53:52	~18 min	`android`	📦`apk` 📲

✔️	`c0ffa39`	#8	2020-03-11 07:43:56	~12 min	`ios`	📦`ipa` 📲
✔️	`c0ffa39`	#8	2020-03-11 07:50:24	~19 min	`android`	📦`apk` 📲
✔️	`c0ffa39`	#8	2020-03-11 07:56:10	~25 min	`android-e2e`	📦`apk` 📲

❌	`196dfbf`	#9	2020-03-19 15:33:20	~4 min	`android`	📄`log`
❌	`196dfbf`	#9	2020-03-19 15:35:50	~6 min	`android-e2e`	📄`log`
❌	`196dfbf`	#9	2020-03-19 15:38:31	~9 min	`ios`	📄`log`

❌	`3cf0f29`	#10	2020-03-21 14:12:03	~4 min	`android`	📄`log`
❌	`3cf0f29`	#10	2020-03-21 14:12:04	~4 min	`android-e2e`	📄`log`
✔️	`3cf0f29`	#10	2020-03-21 14:17:50	~10 min	`ios`	📦`ipa` 📲

❌	`2548e89`	#11	2020-03-23 09:37:11	~13 min	`android`	📄`log`
❌	`2548e89`	#11	2020-03-23 09:39:48	~15 min	`android-e2e`	📄`log`
✔️	`2548e89`	#11	2020-03-23 09:51:02	~26 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`9924d24`	#12	2020-04-07 15:43:46	~9 min	`android`	📦`apk` 📲
✔️	`9924d24`	#12	2020-04-07 15:44:02	~9 min	`ios`	📦`ipa` 📲
✔️	`9924d24`	#12	2020-04-07 15:50:43	~16 min	`android-e2e`	📦`apk` 📲

❌	`ed18e1b`	#13	2020-04-09 11:06:36	~8 min	`ios`	📄`log`
❌	`ed18e1b`	#13	2020-04-09 11:10:36	~12 min	`android-e2e`	📄`log`
❌	`ed18e1b`	#13	2020-04-09 11:14:15	~16 min	`android`	📄`log`

dependency-lockfile-snitch · 2020-03-05T09:04:33Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

status-im-auto · 2020-03-05T09:18:38Z

✔️ status-react/prs/ios/PR-10131#2 🔹 ~13 min 🔹 `d536a92` 🔹 📦 ios package

errorists · 2020-03-05T11:48:49Z

comment on first round of tests with a couple buttons that already work
animation appears smooth if the UI thread isn't clogged (see invite friends button), I believe the easing curve, properties and timing are also spot on, tho it might require more testing. The light knock haptic feedback effect we have on iOS is super subtle and very nice. On Android I didn't notice any, which is good as my device doesn't seem to have a haptic feedback engine. There's the added ripple effect that Android had for years now, I think it's a nice touch, we should keep it.

👏 great 👏 work! 👏

dependency-lockfile-snitch · 2020-03-06T14:33:13Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-09T09:18:59Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-09T10:52:42Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-09T11:06:46Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-09T11:35:09Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

src/status_im/network/ui/edit_network/views.cljs

src/status_im/ui/components/button.cljs

src/status_im/ui/components/button/animated.cljs

errorists · 2020-03-09T12:17:51Z

Issue 1:
Can't cancel taps. Once you press your thumb on any button, there's no way going back :( The right way: you can remove your finger from the button and then lift it, cancelling the press.

Issue 2:
Some buttons are missing text labels and using incorrect styling, for example here the margin surrounding the button is insane

Issue 3:
Floating buttons aren't using this touchable style (Chat +, Wallet Send, Browser select account)

Issue 4:
When I drag on bottom sheets, it registers button presses, so you can't drag the sheet without accidentally pressing any of the buttons :(

dependency-lockfile-snitch · 2020-03-11T07:30:53Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-19T15:29:03Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-21T14:07:39Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-03-23T08:25:06Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-04-07T15:34:29Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

dependency-lockfile-snitch · 2020-04-09T10:57:42Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

Ferossgp · 2020-05-08T12:40:12Z

Animations will be picked when the Button Component will be added into Quo. Now closing as the PR is outdated

Ferossgp added the design-review label Mar 5, 2020

Ferossgp requested review from errorists and flexsurfer March 5, 2020 08:31

Ferossgp requested review from jakubgs and a team as code owners March 5, 2020 08:31

Ferossgp self-assigned this Mar 5, 2020

Ferossgp force-pushed the add-animation-to-numpad branch from d536a92 to 418da35 Compare March 6, 2020 14:33

Ferossgp force-pushed the add-animation-to-numpad branch from 418da35 to 88bdefc Compare March 9, 2020 09:18

Ferossgp requested a review from a team March 9, 2020 09:18

Ferossgp force-pushed the add-animation-to-numpad branch from d7f1190 to cd2c489 Compare March 9, 2020 11:06

Ferossgp force-pushed the add-animation-to-numpad branch from cd2c489 to 0d12fc2 Compare March 9, 2020 11:35

Ferossgp commented Mar 9, 2020

View reviewed changes

src/status_im/network/ui/edit_network/views.cljs Outdated Show resolved Hide resolved

Ferossgp commented Mar 9, 2020

View reviewed changes

src/status_im/ui/components/button.cljs Show resolved Hide resolved

Ferossgp commented Mar 9, 2020

View reviewed changes

src/status_im/ui/components/button/animated.cljs Outdated Show resolved Hide resolved

Ferossgp force-pushed the add-animation-to-numpad branch from 0d12fc2 to c0ffa39 Compare March 11, 2020 07:30

Ferossgp force-pushed the add-animation-to-numpad branch from c0ffa39 to 196dfbf Compare March 19, 2020 15:29

Ferossgp force-pushed the add-animation-to-numpad branch from 196dfbf to 3cf0f29 Compare March 21, 2020 14:07

Ferossgp force-pushed the add-animation-to-numpad branch from 3cf0f29 to 2548e89 Compare March 23, 2020 08:25

Ferossgp mentioned this pull request Mar 25, 2020

Fix android tabbar animation #10191

Merged

Ferossgp force-pushed the add-animation-to-numpad branch from 2548e89 to 9924d24 Compare April 7, 2020 15:34

Ferossgp added 3 commits April 9, 2020 13:46

Add reanimated lib

463f28f

Add animation to button and update styles

86bcd11

Update usage for all buttons and toolbar

ed18e1b

Ferossgp force-pushed the add-animation-to-numpad branch from 9924d24 to ed18e1b Compare April 9, 2020 10:57

weekly-digest bot mentioned this pull request Apr 26, 2020

Weekly Digest (19 April, 2020 - 26 April, 2020) #10435

Closed

Ferossgp closed this May 8, 2020

jakubgs deleted the add-animation-to-numpad branch September 21, 2022 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Add animation to numpad and button component #10131

WIP Add animation to numpad and button component #10131

Ferossgp commented Mar 5, 2020

dependency-lockfile-snitch bot commented Mar 5, 2020

status-github-bot bot commented Mar 5, 2020

status-im-auto commented Mar 5, 2020 •

edited

Loading

dependency-lockfile-snitch bot commented Mar 5, 2020

status-im-auto commented Mar 5, 2020

errorists commented Mar 5, 2020

dependency-lockfile-snitch bot commented Mar 6, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

errorists commented Mar 9, 2020 •

edited

Loading

dependency-lockfile-snitch bot commented Mar 11, 2020

dependency-lockfile-snitch bot commented Mar 19, 2020

dependency-lockfile-snitch bot commented Mar 21, 2020

dependency-lockfile-snitch bot commented Mar 23, 2020

dependency-lockfile-snitch bot commented Apr 7, 2020

dependency-lockfile-snitch bot commented Apr 9, 2020

Ferossgp commented May 8, 2020

WIP Add animation to numpad and button component #10131

WIP Add animation to numpad and button component #10131

Conversation

Ferossgp commented Mar 5, 2020

dependency-lockfile-snitch bot commented Mar 5, 2020

status-github-bot bot commented Mar 5, 2020

Pull Request Checklist

status-im-auto commented Mar 5, 2020 • edited Loading

Jenkins Builds

dependency-lockfile-snitch bot commented Mar 5, 2020

status-im-auto commented Mar 5, 2020

✔️ status-react/prs/ios/PR-10131#2 🔹 ~13 min 🔹 d536a92 🔹 📦 ios package

errorists commented Mar 5, 2020

dependency-lockfile-snitch bot commented Mar 6, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

dependency-lockfile-snitch bot commented Mar 9, 2020

errorists commented Mar 9, 2020 • edited Loading

dependency-lockfile-snitch bot commented Mar 11, 2020

dependency-lockfile-snitch bot commented Mar 19, 2020

dependency-lockfile-snitch bot commented Mar 21, 2020

dependency-lockfile-snitch bot commented Mar 23, 2020

dependency-lockfile-snitch bot commented Apr 7, 2020

dependency-lockfile-snitch bot commented Apr 9, 2020

Ferossgp commented May 8, 2020

status-im-auto commented Mar 5, 2020 •

edited

Loading

✔️ status-react/prs/ios/PR-10131#2 🔹 ~13 min 🔹 `d536a92` 🔹 📦 ios package

errorists commented Mar 9, 2020 •

edited

Loading