Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added navigationBarColor to style #10327

Closed
wants to merge 3 commits into from
Closed

fix: added navigationBarColor to style #10327

wants to merge 3 commits into from

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Apr 14, 2020 •
edited by StatusWrike
Loading

fixes #10253

Summary

Added an item in the styles to set the navigation bar color depending on whether the dark mode is enabled or not. This option is available starting from (Android api 27 ( 8.1 - oreo)), so it should work on the xiao mi note 9 (I could not replicate the issue using simulator / phone).

Platforms

  • Android

status: ready

@richard-ramos richard-ramos requested a review from a team as a code owner April 14, 2020 14:05
@status-github-bot
Copy link

Hey @richard-ramos, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 14, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Apr 14, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e41057b #1 2020-04-14 14:15:15 ~9 min ios 📦ipa 📲
✔️ e41057b #1 2020-04-14 14:19:30 ~13 min android 📦apk 📲
✔️ e41057b #1 2020-04-14 14:19:46 ~14 min android-e2e 📦apk 📲
✔️ 4329db8 #3 2020-04-14 15:54:18 ~10 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b97e753 #4 2020-04-14 16:02:33 ~10 min android 📦apk 📲
✔️ b97e753 #4 2020-04-14 16:04:44 ~12 min ios 📦ipa 📲
✔️ b97e753 #4 2020-04-14 16:07:16 ~15 min android-e2e 📦apk 📲
❌ 164364f #5 2020-04-17 20:40:55 ~32 sec ios 📄log
✔️ 164364f #5 2020-04-17 20:50:19 ~9 min android-e2e 📦apk 📲
✔️ 164364f #5 2020-04-17 20:53:33 ~13 min android 📦apk 📲
✔️ 164364f #6 2020-04-27 10:12:45 ~9 min android 📦apk 📲

@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Apr 14, 2020
andremedeiros
andremedeiros approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@andremedeiros andremedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 91
Failed tests: 1
Passed tests: 90

Failed tests (1)

Click to expand
1. test_wallet_set_up

Device 1: Looking for an element by text part: 'These three words prove that a transaction is safe.'
Device 1: Looking for an element by text part: 'You should see these words before signing each transaction. If you don't, cancel and sign out.'

'These three words prove that a transaction is safe.' text is not displayed 'You should see these words before signing each transaction. If you don't, cancel and sign out.' text is not displayed 'These three words prove that a transaction is sa

Device sessions

Passed tests (90)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history (TestRail link is not found)
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_send_message_to_newly_added_contact
Device sessions

22. test_share_contact_code_and_wallet_address
Device sessions

23. test_connection_is_secure
Device sessions

24. test_add_to_contacts
Device sessions

25. test_add_account_to_multiaccount_instance_private_key
Device sessions

26. test_refresh_button_browsing_app_webview
Device sessions

27. test_can_add_existing_ens
Device sessions

28. test_transaction_wrong_password_wallet
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_text_message_1_1_chat
Device sessions

31. test_can_use_purchased_stickers_on_recovered_account
Device sessions

32. test_open_transaction_on_etherscan
Device sessions

33. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

34. test_contact_profile_view
Device sessions

35. test_offline_add_new_group_chat_member
Device sessions

36. test_logcat_backup_recovery_phrase
Device sessions

37. test_start_chat_with_ens
Device sessions

38. test_add_and_remove_contact_from_public_chat
Device sessions

39. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

40. test_open_blocked_site
Device sessions

41. test_open_chat_by_pasting_public_key
Device sessions

42. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

43. test_ens_username_recipient
Device sessions

44. test_token_with_more_than_allowed_decimals
Device sessions

45. test_fetch_more_history_in_empty_chat
Device sessions

46. test_open_public_chat_using_deep_link
Device sessions

47. test_switch_users_and_add_new_account
Device sessions

48. test_add_account_to_multiaccount_instance_generate_new
Device sessions

49. test_copy_contact_code_and_wallet_address
Device sessions

50. test_send_transaction_from_daap
Device sessions

51. test_send_eth_to_ens
Device sessions

52. test_send_two_transactions_one_after_another_in_dapp
Device sessions

53. test_message_marked_as_sent_in_1_1_chat
Device sessions

54. test_long_press_delete_clear_all_dapps
Device sessions

55. test_copy_and_paste_messages
Device sessions

56. test_deploy_contract_from_daap
Device sessions

57. test_back_forward_buttons_browsing_website
Device sessions

58. test_password_in_logcat_creating_account
Device sessions

59. test_add_custom_token
Device sessions

60. test_sign_message_from_daap
Device sessions

61. test_dapps_permissions
Device sessions

62. test_request_public_key_status_test_daap
Device sessions

63. test_logcat_send_transaction_from_wallet
Device sessions

64. test_long_press_to_delete_chat
Device sessions

65. test_log_level_and_fleet
Device sessions

66. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

67. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions

68. test_send_eth_in_1_1_chat
Device sessions

69. test_ens_in_public_and_1_1_chats
Device sessions

70. test_block_user_from_public_chat
Device sessions

71. test_fetching_balance_after_offline
Device sessions

72. test_logcat_sign_message_from_daap
Device sessions

73. test_offline_status
Device sessions

74. test_manage_assets
Device sessions

75. test_offline_messaging_1_1_chat
Device sessions

76. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

77. test_add_new_keycard_account
Device sessions

78. test_send_token_with_7_decimals
Device sessions

79. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

80. test_pass_phrase_validation
Device sessions

81. test_send_emoji
Device sessions

82. test_filters_from_daap
Device sessions

83. test_redirect_to_public_chat_tapping_tag_message
Device sessions

84. test_logcat_send_transaction_from_daap
Device sessions

85. test_send_eth_from_wallet_to_address
Device sessions

86. test_send_stt_from_wallet
Device sessions

87. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

88. test_messaging_in_different_networks
Device sessions

89. test_collectible_from_wallet_opens_in_browser_view
Device sessions

90. test_insufficient_funds_wallet_positive_balance
Device sessions

@richard-ramos richard-ramos force-pushed the fix/navbar-darkmode branch 2 times, most recently from a74d0d1 to 4329db8 Compare April 14, 2020 15:44
@richard-ramos
fix: added navigationBarColor to style
0398f4f 
Signed-off-by: Your Name <Your.Name@example.com>
@richard-ramos
fix: change navigation bar button colors depending on mode
b97e753 
Signed-off-by: Your Name <Your.Name@example.com>
@Serhy Serhy moved this from E2E Tests to TO TEST in Pipeline for QA Apr 15, 2020
@Serhy Serhy moved this from TO TEST to IN TESTING in Pipeline for QA Apr 15, 2020
@Serhy
Copy link
Contributor

Serhy commented Apr 15, 2020 •
edited
Loading

@richard-ramos thanks a lot for fix! But something wrong on my Samsung S8 (Android9) (latest https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200414-155212-b97e75-pr-universal.apk build tested)

This is when Night mode=ON + System/Dark appearance in Status settings:
Screenshot 2020-04-15 at 14 06 36
(issues in this case are that toggle-buttons in ON state, cursors in input fields are with turquoise colour and the device bottom panel has no changes VS develop build)

This is Night mode=ON + Light appearance in Status settings:
Screenshot 2020-04-15 at 14 07 45
(Issues: toggle-buttons in ON state, cursors in input fields are with turquoise

Nightly mode=OFF + System/Light appearance in Status settings:
Screenshot 2020-04-15 at 14 10 18
(Issue is in that case is that bottom hardware panel (apart button borders) is white)

Nightly mode=OFF + Dark mode appearance in Status settings:
Screenshot 2020-04-15 at 14 11 38
(Same bug as in previous case: whitened bottom hardware panel)

@Serhy Serhy moved this from IN TESTING to CONTRIBUTOR in Pipeline for QA Apr 15, 2020
@dependency-lockfile-snitch
Copy link

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@richard-ramos
Copy link
Member Author

@Serhy thank you for reporting back those issues.
The latest commit should fix them!

@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
@flexsurfer flexsurfer moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA Apr 24, 2020
@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 91
Failed tests: 2
Passed tests: 89

Failed tests (2)

Click to expand
1. test_wallet_set_up

Device 1: Looking for an element by text part: 'These three words prove that a transaction is safe.'
Device 1: Looking for an element by text part: 'You should see these words before signing each transaction. If you don't, cancel and sign out.'

'These three words prove that a transaction is safe.' text is not displayed 'You should see these words before signing each transaction. If you don't, cancel and sign out.' text is not displayed 'These three words prove that a transaction is sa

Device sessions

2. test_add_and_remove_contact_from_public_chat

Device 1: Tap on StartNewChatButton
Device 1: Wait for UserNameBelowNewChatButton

'Remove from contacts' is not changed to 'Add to contacts' List of contacts in profile contains removed user "Add to contacts" button is not shown in 1-1 after removing user from contacts List of contacts below "Start new chat" contains re

Device sessions

Passed tests (89)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_offline_status
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_open_chat_by_pasting_public_key
Device sessions

7. test_back_forward_buttons_browsing_website
Device sessions

8. test_password_in_logcat_creating_account
Device sessions

9. test_can_use_purchased_stickers_on_recovered_account
Device sessions

10. test_modify_transaction_fee_values
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_logcat_backup_recovery_phrase
Device sessions

15. test_unread_messages_counter_public_chat
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp
Device sessions

17. test_message_marked_as_sent_in_1_1_chat
Device sessions

18. test_user_can_switch_network
Device sessions

19. test_public_chat_clear_history (TestRail link is not found)
Device sessions

20. test_timestamp_in_chats
Device sessions

21. test_delete_chats_via_delete_button
Device sessions

22. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

23. test_fetch_more_history_in_empty_chat
Device sessions

24. test_mobile_data_usage_popup_continue_syncing
Device sessions

25. test_add_to_contacts
Device sessions

26. test_dapps_permissions
Device sessions

27. test_long_press_delete_clear_all_dapps
Device sessions

28. test_need_help_section
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_offline_messaging_1_1_chat
Device sessions

31. test_token_with_more_than_allowed_decimals
Device sessions

32. test_add_account_to_multiaccount_instance_private_key
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_install_pack_and_send_sticker
Device sessions

35. test_send_eth_in_1_1_chat
Device sessions

36. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

37. test_send_emoji
Device sessions

38. test_copy_and_paste_messages
Device sessions

39. test_add_account_to_multiaccount_instance_generate_new
Device sessions

40. test_send_eth_from_wallet_to_address
Device sessions

41. test_messaging_in_different_networks
Device sessions

42. test_start_chat_with_ens
Device sessions

43. test_logcat_recovering_account
Device sessions

44. test_offline_add_new_group_chat_member
Device sessions

45. test_connection_is_secure
Device sessions

46. test_send_eth_to_ens
Device sessions

47. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

48. test_long_press_to_delete_chat
Device sessions

49. test_send_transaction_from_daap
Device sessions

50. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

51. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

52. test_open_blocked_site
Device sessions

53. test_refresh_button_browsing_app_webview
Device sessions

54. test_pass_phrase_validation
Device sessions

55. test_send_token_with_7_decimals
Device sessions

56. test_sign_message_from_daap
Device sessions

57. test_deploy_contract_from_daap
Device sessions

58. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions

59. test_add_new_keycard_account
Device sessions

60. test_add_custom_token
Device sessions

61. test_decline_transactions_in_1_1_chat
Device sessions

62. test_send_and_open_links
Device sessions

63. test_manage_assets
Device sessions

64. test_share_contact_code_and_wallet_address
Device sessions

65. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

66. test_redirect_to_public_chat_tapping_tag_message
Device sessions

67. test_block_user_from_public_chat
Device sessions

68. test_ens_in_public_and_1_1_chats
Device sessions

69. test_sign_typed_message
Device sessions

70. test_create_new_group_chat
Device sessions

71. test_password_in_logcat_sign_in
Device sessions

72. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

73. test_send_message_to_newly_added_contact
Device sessions

74. test_logcat_sign_message_from_daap
Device sessions

75. test_mobile_data_usage_popup_stop_syncing
Device sessions

76. test_collectible_from_wallet_opens_in_browser_view
Device sessions

77. test_logcat_send_transaction_from_daap
Device sessions

78. test_contact_profile_view
Device sessions

79. test_switch_users_and_add_new_account
Device sessions

80. test_logcat_send_transaction_from_wallet
Device sessions

81. test_filters_from_daap
Device sessions

82. test_send_stt_from_wallet
Device sessions

83. test_login_with_new_account
Device sessions

84. test_home_view
Device sessions

85. test_log_level_and_fleet
Device sessions

86. test_can_add_existing_ens
Device sessions

87. test_copy_contact_code_and_wallet_address
Device sessions

88. test_fetching_balance_after_offline
Device sessions

89. test_can_see_all_transactions_in_history
Device sessions

@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@flexsurfer
Copy link
Member

ping @Serhy

@Serhy Serhy moved this from E2E Tests to IN TESTING in Pipeline for QA Apr 27, 2020
@status-im-auto
Copy link
Member

0% of end-end tests have passed

Total executed tests: 2
Failed tests: 2
Passed tests: 0

Failed tests (2)

Click to expand
1. test_wallet_set_up

Device 1: Looking for an element by text part: 'These three words prove that a transaction is safe.'
Device 1: Looking for an element by text part: 'You should see these words before signing each transaction. If you don't, cancel and sign out.'

'These three words prove that a transaction is safe.' text is not displayed 'You should see these words before signing each transaction. If you don't, cancel and sign out.' text is not displayed 'These three words prove that a transaction is sa

Device sessions

2. test_add_and_remove_contact_from_public_chat

Device 1: Tap on StartNewChatButton
Device 1: Wait for UserNameBelowNewChatButton

'Remove from contacts' is not changed to 'Add to contacts' List of contacts in profile contains removed user "Add to contacts" button is not shown in 1-1 after removing user from contacts List of contacts below "Start new chat" contains re

Device sessions

@Serhy
Copy link
Contributor

Serhy commented Apr 27, 2020 •
edited
Loading

@richard-ramos I have a weird behavior with on Android 9, whenn night mode is enabled: app crashes right away after Status app starts:
Screenshot 2020-04-27 at 13 30 58

There is no crash though, with "Night mode" disabled (no bugs with default 'Light mode'+Night Mode=OFF)
But if I try to switch to Dark mode while in app - the 'Undefined error' appears again:

ssw3w3e3e

Logcat logs:


04-27 13:15:04.409  4201  4315 D ReactNativeJS: DEBUG [status-im.native-module.core:265] - [native-module] get-device-model-info
04-27 13:15:04.514  4201  4315 D ReactNativeJS: DEBUG [status-im.native-module.core:182] - [native-module]  set-soft-input-mode
04-27 13:15:04.514  4201  4321 D StatusModule: setSoftInputMode
04-27 13:15:04.519  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.logging.core:26] - 
04-27 13:15:04.522  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.handlers:25] - Handling re-frame event:  :init/app-started
04-27 13:15:04.524  4201  4315 I ReactNativeJS: INFO [status-im.hardwallet.card:19] - [keycard] check-nfc-support
04-27 13:15:04.525  4201  4315 I ReactNativeJS: PRETTY PRINTED EXCEPTION
04-27 13:15:04.525  4201  4315 I ReactNativeJS: 
04-27 13:15:04.525  4201  4315 I ReactNativeJS: ***
04-27 13:15:04.525  4201  4315 I ReactNativeJS: NAME: "TypeError"
04-27 13:15:04.525  4201  4315 I ReactNativeJS: MESSAGE: undefined is not a function
04-27 13:15:04.525  4201  4315 I ReactNativeJS: 
04-27 13:15:04.525  4201  4315 I ReactNativeJS: TypeError: undefined is not a function
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at MVn (address at index.android.bundle:1:1886520)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at ckl (address at index.android.bundle:1:3532304)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:2984229)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at UUn (address at index.android.bundle:1:1836767)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at Jqn (address at index.android.bundle:1:1876661)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at uQn (address at index.android.bundle:1:1879889)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:3738412)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:1760577)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at v (address at index.android.bundle:1:31237)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at d (address at index.android.bundle:1:30887)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at o (address at index.android.bundle:1:30556)
04-27 13:15:04.525  4201  4315 I ReactNativeJS:     at global (address at index.android.bundle:1:30288)
04-27 13:15:04.525  4201  4315 I ReactNativeJS: 
04-27 13:15:04.525  4201  4315 I ReactNativeJS: ***
04-27 13:15:04.527  4201  4315 I ReactNativeJS: Running "StatusIm" with {"rootTag":1}
04-27 13:15:04.527  4201  4315 I ReactNativeJS: PRETTY PRINTED EXCEPTION
04-27 13:15:04.527  4201  4315 I ReactNativeJS: 
04-27 13:15:04.527  4201  4315 I ReactNativeJS: ***
04-27 13:15:04.527  4201  4315 I ReactNativeJS: NAME: "Invariant Violation"
04-27 13:15:04.527  4201  4315 I ReactNativeJS: MESSAGE: "StatusIm" has not been registered. This can happen if:
04-27 13:15:04.527  4201  4315 I ReactNativeJS: * Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
04-27 13:15:04.527  4201  4315 I ReactNativeJS: * A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called.
04-27 13:15:04.527  4201  4315 I ReactNativeJS: 
04-27 13:15:04.527  4201  4315 I ReactNativeJS: Invariant Violation: "StatusIm" has not been registered. This can happen if:
04-27 13:15:04.527  4201  4315 I ReactNativeJS: * Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
04-27 13:15:04.527  4201  4315 I ReactNativeJS: * A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called.
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:3743007)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at runApplication (address at index.android.bundle:1:4086379)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at apply (native)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at value (address at index.android.bundle:1:3750127)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at anonymous (address at index.android.bundle:1:3748548)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at value (address at index.android.bundle:1:3749724)
04-27 13:15:04.527  4201  4315 I ReactNativeJS:     at value (address at index.android.bundle:1:3748506)
04-27 13:15:04.527  4201  4315 I ReactNativeJS: 
04-27 13:15:04.527  4201  4315 I ReactNativeJS: ***
04-27 13:15:04.530  4201  4315 I ReactNativeJS: INFO [status-im.hardwallet.card:24] - [keycard response] check-nfc-support true
04-27 13:15:04.533  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.handlers:25] - Handling re-frame event:  :update-window-dimensions
04-27 13:15:04.536  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.handlers:25] - Handling re-frame event:  :hardwallet.callback/check-nfc-support-success
04-27 13:15:04.557  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.handlers:25] - Handling re-frame event:  :hardwallet.callback/on-retrieve-pairings-success
04-27 13:15:10.618  4201  4315 D ReactNativeJS: DEBUG [status-im.utils.handlers:25] - Handling re-frame event:  :logging.ui/send-logs-pressed
04-27 13:15:10.625  4201  4315 D ReactNativeJS: DEBUG [status-im.native-module.core:235] - [native-module] send-logs
04-27 13:15:10.626  4201  4321 D StatusModule: sendLogs

@Serhy Serhy moved this from IN TESTING to CONTRIBUTOR in Pipeline for QA Apr 27, 2020
@dependency-lockfile-snitch
Copy link

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@flexsurfer
Copy link
Member

@richard-ramos any updates on this one ?

@richard-ramos
Copy link
Member Author

I have not been able to reproduce this issue on simulator :(

@flexsurfer
Copy link
Member

fixed here #10846

@flexsurfer flexsurfer closed this Jun 18, 2020
Pipeline for QA automation moved this from CONTRIBUTOR to DONE Jun 18, 2020
@jakubgs jakubgs deleted the fix/navbar-darkmode branch September 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andremedeiros andremedeiros andremedeiros approved these changes

@cammellos cammellos cammellos approved these changes

@vkjr vkjr Awaiting requested review from vkjr

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
request-manual-qa Tested - Issues
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom system panel is white on dark mode on Android
6 participants
@richard-ramos @status-im-auto @Serhy @flexsurfer @andremedeiros @cammellos