feat: add jump-to button in group-detail screen #19134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (23)
|
flexsurfer
reviewed
Mar 8, 2024
flexsurfer
reviewed
Mar 8, 2024
| @@ -166,4 +168,15 @@ | |||
| :render-section-footer-fn contacts-section-footer | |||
| :render-data {:chat-id chat-id | |||
| :admin? admin?} | |||
| :render-fn contact-item-render}]])) | |||
| :render-fn contact-item-render}] | |||
| [quo/floating-shell-button | |||
There was a problem hiding this comment.
hey @Parveshdhull instead of adding this to each screen do you think it would be possible just to have :shell-button? true option for the screen?
There was a problem hiding this comment.
Hi @flexsurfer, that's great suggestion.
How about we just use this button also as a overlay similar to alert banner.
Because foating button supposed to use custom animation of fading instead of folding with closed screen. (Check out home screen animation of floating button for reference)
There was a problem hiding this comment.
agree with @flexsurfer here, should be a generic solution where possible 👍
codemaster115
force-pushed
the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
from
942ead7
to
3b71465
Compare
codemaster115
force-pushed
the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
from
ea121c2
to
7baa265
Compare
| :render-fn contact-item-render}]])) | ||
| :render-fn contact-item-render}] | ||
| [quo/floating-shell-button | ||
| {:key :shell |
There was a problem hiding this comment.
why key?
(we also have similar :key and :on-press in status-im.contexts.profile.settings.view, needs to be refactored)
(will be addressed in #19192)
There was a problem hiding this comment.
please remove this key, I am not sure why we added in settings page. Also this might show an error component with duplicate key etc... (if being used, but here :key will be just ignored)
Parveshdhull
approved these changes
Mar 18, 2024
94% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
96% of end-end tests have passedFailed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
codemaster115
force-pushed
the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
from
4519da2
to
4e1db1a
Compare
|
Hi @codemaster115 ! I've checked iOS and Android and really button now is present there. ISSUE 1: Jump to button doesn't redirect user to the Jump to screen Expected result: user can tap on Jump to button and be redirected to the Jump to screen *iOS and Android |
codemaster115
force-pushed
the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
from
4e1db1a
to
927ec6a
Compare
codemaster115
force-pushed
the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
from
927ec6a
to
474a5c9
Compare
|
Hi @codemaster115 ! |
codemaster115
deleted the
19122-the-jump-to-button-is-missing-on-the-group-details-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number
otherwise
fixes #19122
Summary
This PR is to add the jump-to floating button in group detail screen.
Platforms
Areas that maybe impacted
Functional
Steps to test
Before and after screenshots comparison
status: ready