Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add indexOf method to array/complex64 #1191

Merged
merged 14 commits into from
Dec 19, 2023
Merged

feat: add indexOf method to array/complex64 #1191

merged 14 commits into from
Dec 19, 2023

Conversation

Jaysukh-409
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array indexOf method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 18, 2023
@kgryte kgryte changed the title feat: add support for the typed array indexOf method in array/complex64 feat: add indexOf method to array/complex64 Dec 18, 2023
@kgryte
Apply suggestions from code review
d918c42 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
de2880f 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
eb8f210 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
18cd4d2 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
3e6393d 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
072593f 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
ea55ae9 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 707fed5 into stdlib-js:develop Dec 19, 2023
7 checks passed
@kgryte kgryte deleted the complexIndexOf branch December 19, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte