fix: resolve issue with prev-grapheme-cluster-break function #1431
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Mar 1, 2024
|
@kgryte , @Pranavchiku, @Planeshifter Please check the integrity of this PR, and send reviews |
1 task
kgryte
reviewed
Mar 9, 2024
| @@ -99,7 +99,9 @@ function prevGraphemeClusterBreak( str, fromIndex ) { | |||
|
|
|||
| // Get the corresponding grapheme break and emoji properties: | |||
| breaks.push( breakProperty( cp ) ); | |||
| emoji.push( emojiProperty( cp ) ); | |||
| if (!(cp >= 0x1F3FB && cp <= 0x1F3FF)) { // Check if the character is not a skin tone modifier | |||
There was a problem hiding this comment.
This is too narrow a patch. It is not just skin tones, TMK, but any modifier. The implementation more generally should be refactored to ensure that grapheme clusters comprised of multiple code points are handled correctly.
There was a problem hiding this comment.
Oh I am sorry, I got confused by seeing the original issue being raised about the colour tone.
I will try to debug and propose a generic solution to this as soon as possible.
Thank You.
kgryte
reviewed
Mar 9, 2024
| @@ -114,7 +116,9 @@ function prevGraphemeClusterBreak( str, fromIndex ) { | |||
|
|
|||
| // Get the corresponding grapheme break and emoji properties: | |||
| breaks.push( breakProperty( cp ) ); | |||
| emoji.push( emojiProperty( cp ) ); | |||
| if (!(cp >= 0x1F3FB && cp <= 0x1F3FF)) { // Check if the character is not a skin tone modifier | |||
kgryte
added
the
Needs Changes
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1092 .
Description
There's an issue with prevGraphemeClusterBreak package, if I compare the results with nextGraphemeClusterBreak for a single skin tone emoji it doesn't return the same values,
Related Issues
This pull request:
prevGraphemeClusterBreakpackage #1092Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers