Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/tand #1771

Merged
merged 6 commits into from
Mar 15, 2024
Merged

feat: add math/base/special/tand #1771

merged 6 commits into from
Mar 15, 2024

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024 •
edited
Loading

Resolves #34

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
@Planeshifter Planeshifter changed the title feat: added math/base/special/tand feat: add math/base/special/tand Mar 8, 2024
@Planeshifter Planeshifter added the Math Issue or pull request specific to math functionality. label Mar 8, 2024
@the-r3aper7
Copy link
Contributor Author

@Planeshifter this PR is ready for review.

@Planeshifter
Apply suggestions from code review
f4d80c8 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@github-actions github-actions bot added the Documentation Improvements, additions, or changes to documentation. label Mar 15, 2024
Planeshifter
Planeshifter approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge shortly.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 15, 2024
@Planeshifter Planeshifter merged commit 025c2c1 into stdlib-js:develop Mar 15, 2024
8 checks passed
@the-r3aper7 the-r3aper7 deleted the tand branch March 15, 2024 01:56
@kgryte
Copy link
Member

kgryte commented Mar 15, 2024

@the-r3aper7 Would you mind checking the box indicating that you've read the contributing guidelines? We need to ensure this in order to ensure compliance with project licensing terms. Thanks!

@kgryte kgryte removed the Documentation Improvements, additions, or changes to documentation. label Mar 15, 2024
@the-r3aper7 the-r3aper7 mentioned this pull request Mar 15, 2024
Closed
5 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Mar 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tand
3 participants
@the-r3aper7 @kgryte @Planeshifter