Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progressive loading guide issues #1002

Closed
3 tasks
matthewp opened this issue Jan 14, 2017 · 0 comments · Fixed by #1010
Closed
3 tasks

Progressive loading guide issues #1002

matthewp opened this issue Jan 14, 2017 · 0 comments · Fixed by #1010
Assignees
@matthewp
Labels
developer relations documentation essential p0

Comments

@matthewp
Copy link
Member

matthewp commented Jan 14, 2017 •
edited
Loading

There's a couple of issues in the guide:

  • - At this step the myhub.js uses backtick strings for multi-line and then later you update it here and it's using normal strings with concatenation.
  • - The export script uses system instead of steal property.
  • - Updating the myhub.js to include the puppies code is done in the "Build Production app" section where it doesn't really belong.
matthewp added a commit that referenced this issue Jan 18, 2017
@matthewp
Update progressive loading guide
4b8efe6 
This updates the progressive loading guide with some fixes to issues I
found while giving a training. They are:

* Inconsistent string usage between two versions of myhub.js
* Updating the main myhub.js to load the puppies page inside of the Build Production... section, so I moved it to before that section.
* In the Exporting... section it was using the `system` property instead
* of the `steal` property.

Closes #1002
@matthewp matthewp mentioned this issue Jan 18, 2017
Merged
@matthewp matthewp self-assigned this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
developer relations documentation essential p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update progressive loading guide stealjs/steal
2 participants
@matthewp @chasenlehara