Fix iPhone X elements that are too close to screen edges

[apike]

We should build master on Xcode for the iPhone X simulator, note what issues there are in this issue, and prep a patch.

[abey]

iPhone X Simulator Test Run

• An extension of Issue iOS simulator (at least on MacBook Air) takes very long time to time out traceroute #474, everything on iPhone X Simulator (on MacBook Air) is awfully slow.
• We may have to shift the views a little higher to prevent UI issues.
  
• Credits page close button (I don't think we should change this as it doesn't look bad)
  
• Decrease the size of "Visit cogecopeer1.com" button on About Cogeco Peer 1 page since the lower portion of the letter "g" is not visible.
  

Should I open new issues for any of these @apike?

[apike]

Definitely all three of those are too close to the edges, so we'll need to do a pass on this. It looks like the items too close to the bottom would be fine to bump up, but the X button could use a new look/asset that will work both on the X and on other devices, probably by insetting it from the corner, and maybe making it circular. @rachteo can you do a quick pass on that?

[rachteo]

Can we bump the menu icons down 40pt and distribute them evenly across the top of the screen? And conversely, bump up the timeline and buttons and things by 40pt

[rachteo]

For the close button, I'd suggest just moving it further down so that it's in line with where the menu would be, which is in line with what Apple seems to be doing with their own apps

[apike]

Seems reasonable to me - Is 40pt the "safe area margin" that we get from the iOS APIs?

Also, spacing the icons evenly on iPhones seems reasonable, as long as it doesn't look silly on the iPhone Plus.

[ssawchenko]

I have applied the safe area constraints to all ViewControllers except CreditsViewController. CreditsViewController does not have a storyboard and setting up the constraints in Objective C is rather verbose. I looked into converting into Swift, however, I ran into a bunch of issues (including a linker error) - if @nbrooke could look into converting CreditsViewController to swift I feel it would a better use of the project hours.

Once again, I have done the iPhoneX conversion on other pages, I just need CreditsViewController converted to swift or converted to use a Storyboard.

[nbrooke]

Did the Swift conversion of CreditsViewController yesterday, it's ready to try as pull request #492

[ssawchenko]

Whoops, I see that PR in my email inbox (sorry!). I'll check it out.

[ssawchenko]

@rachteo

Can we bump the menu icons down 40pt and distribute them evenly across the top of the screen? And conversely, bump up the timeline and buttons and things by 40pt

Do you mean 40pt from the top of the device, or 40pts from the top of iPhoneX's "safe area"? Applying 40pts from the safe area puts the menu here:

Adhering to the top of the safe area puts the menu here:

[apike]

@ssawchenko Definitely the second one :)

[ssawchenko]

I realized after I asked that it was a silly question. I perhaps need another cup of coffee ;)