Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBD Stability #230

Closed
mvandeberg opened this issue Aug 1, 2016 · 4 comments
Closed

SBD Stability #230

mvandeberg opened this issue Aug 1, 2016 · 4 comments
Assignees
@mvandeberg
Labels
HARDFORK
Milestone
Hardfork 14

Comments

@mvandeberg
Copy link
Contributor

No description provided.

@mvandeberg mvandeberg added this to the Hardfork 13 milestone Aug 1, 2016
@mvandeberg mvandeberg self-assigned this Aug 1, 2016
mvandeberg pushed a commit that referenced this issue Aug 1, 2016
Implement SBD Stability #230
6f77a71
mvandeberg pushed a commit that referenced this issue Aug 2, 2016
Stabalize limit orders #230
c000f92
@abitmore abitmore mentioned this issue Aug 4, 2016
Closed
mvandeberg pushed a commit that referenced this issue Aug 9, 2016
Initial Test Case #230
0d48067
mvandeberg pushed a commit that referenced this issue Aug 9, 2016
Simplify SBD printing logic. Test upper and lower bound of SBD printing
15896a4 
#230
@bytemaster bytemaster modified the milestones: Hardfork 14, Hardfork 13 Aug 9, 2016
@abitmore
Copy link
Contributor

Interest will still be paid in SBD when new SBD is not being printed as author reward. See the code. Intended?

@abitmore
Copy link
Contributor

Still possible multiplication overflow at this line in database::stabalize_sbd().

And probably need a virtual op to record the forced conversion.

mvandeberg pushed a commit that referenced this issue Aug 10, 2016
Change sad printing to be a linear function over an interval rather t…
1265066 
…han a boolean value. Finished testing. #230
mvandeberg pushed a commit that referenced this issue Aug 15, 2016
Merge branch 'hf14' into 230-sbd-stability #230
39e4433 
Bump to hf 14
mvandeberg pushed a commit that referenced this issue Aug 15, 2016
Merge branch '230-sbd-stability' into develop #230
be80977
@mvandeberg
Copy link
Contributor Author

There is an issue in the current implementation caused by rounding down when converting 1% SBD into STEEM when SBD makes up 20% of the market cap. A user can split their SBD into 99 satoshi portions, which we be penalized each block at a rate of 0 satoshis, effectively avoiding the conversion altogether. SBD stability needs to be updated to round up on the 1% conversion to prevent an account from avoiding the automatic conversion.

mvandeberg pushed a commit that referenced this issue Aug 18, 2016
Add escrow object to sbd stability #143 #230
6de4e87
mvandeberg pushed a commit that referenced this issue Aug 18, 2016
Fix rounding issue with SBD Stability #230
6bbc848
mvandeberg pushed a commit that referenced this issue Aug 23, 2016
FRemove SBD conversion and stabilize SBD through price feed #230
5a7986e
@mvandeberg
Copy link
Contributor Author

Removing NEEDS TESTING label as these changes have already been implemented, tested, and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandeberg mvandeberg

Labels
HARDFORK
Projects
None yet
Milestone
Hardfork 14
Development

No branches or pull requests
3 participants
@bytemaster @abitmore @mvandeberg