Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite swtpm_localca in 'C' #449

Merged
merged 4 commits into from
Jun 1, 2021
Merged

Rewrite swtpm_localca in 'C' #449

merged 4 commits into from
Jun 1, 2021

Conversation

stefanberger
Copy link
Owner

This is a rewrite of swtpm_localca in 'C'.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
@coveralls
Copy link

coveralls commented May 31, 2021

Pull Request Test Coverage Report for Build 3104

  • 429 of 541 (79.3%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 74.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/swtpm_utils.c 47 65 72.31%
samples/swtpm_localca_utils.c 36 55 65.45%
samples/swtpm_localca.c 346 421 82.19%
Files with Coverage Reduction New Missed Lines %
src/utils/swtpm_utils.c 1 84.88%
Totals Coverage Status
Change from base Build 3090: 0.8%
Covered Lines: 5425
Relevant Lines: 7281

💛 - Coveralls

This is a 1:1 rewrite of swtpm_localca in 'C' as a final step to get
rid of the python dependency. It addresses issue #437.

Tested on: Cygwin, Fedora 33, Ubuntu Xenial & Bionic, FreeBSD,
           DragonFlyBSD, OpenBSD (i386), Mac, Debian (recent), Centos-8,
           CentOS (recent), Alpine (recent), OpenSUSE (recent),
           Fedora 28 PPC Big Endian

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Modify a test case and write an environment variable into the
swtpm_setup.conf config file to test that it gets resolved.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
@stefanberger stefanberger merged commit 4ec1788 into master Jun 1, 2021
@stefanberger stefanberger deleted the swtpm_localca_in_c branch June 1, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants