swtpm_setup: Add support for checking for TPM 1.2 and TPM 2 support #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will have to wait until PR #514 has been applied. |
Pull Request Test Coverage Report for Build 3352
💛 - Coveralls |
elmarco
reviewed
Aug 10, 2021
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
master.swtpm_setup_tpm_version_support
branch
from
08f2944
to
0e8caf0
Compare
Implement get_supported_tpm_versions to get swtpm's support for TPM 1.2 and TPM 2 and use it error out in case user choose a TPM version that is not supported. Also display the supported TPM versions in the capabilites JSON. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
master.swtpm_setup_tpm_version_support
branch
from
0e8caf0
to
9500f48
Compare
elmarco
reviewed
Aug 10, 2021
| { | ||
| gboolean success; | ||
| g_autofree gchar *standard_output = NULL; | ||
| int exit_status = 0; |
There was a problem hiding this comment.
if you don't care about exist_status, you may just pass NULL
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement get_supported_tpm_versions to get swtpm's support for TPM 1.2
and TPM 2 and use it error out in case user choose a TPM version that
is not supported. Also display the supported TPM versions in the
capabilites JSON.