swtpm: Implement CheckState interface function #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3482
💛 - Coveralls |
Etsukata
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Thanks @stefanberger, I put a cleanup comment (nvdata). Other than that, it looks good to me.
src/swtpm/swtpm_nvstore.c
Outdated
| @@ -1324,10 +1324,10 @@ int SWTPM_NVRAM_PrintJson(void) | |||
| TPM_RESULT rc = 0; | |||
| int ret = 0, n; | |||
| unsigned char *nvdata = NULL; | |||
There was a problem hiding this comment.
nvdata is no longer used. We can remove this.
There was a problem hiding this comment.
Thanks. Hadn't looked. Updated.
stefanberger
force-pushed
the
stefanberger/backend_is_available
branch
2 times, most recently
from
f0bf00e
to
c8267b5
Compare
Before it was also only looking for availability of the file, so now we have swtpm pretty much do the same and not try out the file. |
stefanberger
force-pushed
the
stefanberger/backend_is_available
branch
from
c8267b5
to
cc4a502
Compare
Remove all interface functions from swtpm_nvstore_dir.h and make them static in swtpm_nvstore_dir.c. This way we avoid direct calls to these functions from elsewhere. Move the declaration of the interface structure into swtpm_nvstore.h to get rid of swtpm_nvstore_dir.h entirely. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
…blob Implement a CheckState interface function for checking for the TPM_PERMANENT_ALL_NAME blog. The dirctory backend does a simple stat on the file without actually reading it, which otherwise may require the (correct) key if it was encrypted. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
stefanberger/backend_is_available
branch
from
cc4a502
to
e9c724d
Compare
Etsukata
approved these changes
Sep 25, 2021
stefanberger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanup on the directory backend and implements a CheckState interface function for checking for availability of the permanent state blob on the backend.
@Etsukata Please have a look.