Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in swtpm_setup and some issues with tests #567

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

stefanberger
Copy link
Owner

This PR fixes a memory leak in swtpm_setup and some issues related to tests.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Auto-free the variables used for holding values read from the config
file.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
clang doesn't link executables built with ASAN support to libasan, like
gcc does, so we have to use nm rather than ldd for checking for whether
the executable was built with ASAN. nm is part of the binutils package
and should be available on all systems where gcc was installed.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3531

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 75.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/swtpm_localca/swtpm_localca.c 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/swtpm_localca/swtpm_localca.c 1 81.97%
Totals Coverage Status
Change from base Build 3529: -0.02%
Covered Lines: 5773
Relevant Lines: 7635

💛 - Coveralls

@stefanberger stefanberger merged commit 3928bd2 into master Sep 29, 2021
@stefanberger stefanberger deleted the stefanberger/fix_memory_leaks branch September 29, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants