When graphics cannot be initialized apply fallback

[stefanhendriks]

From #330 and #536

Case that still remains:

• when windowed mode, and resolution cannot be acquired, the game exits. Instead, it should try different resolutions.

What about:

• if all else fails, try 800x600 (windowed OR fullscreen), and only if that fails abort game?

[pbomta]

With the current implementation (that was already there before I refactored it into cScreenInit), it falls-back to autodetection when fullscreen init was not possible with the vars from game.ini. That would also solve this, right? I tested it. The logs show:

133|INFO|ALLEGRO|Desktop color dept is 32.|Screen init
133|INFO|ALLEGRO|Fullscreen mode requested.|Screen init
525|WARN|ALLEGRO|Failed to initialize full-screen with resolution 1234x600 and color depth 32.|FAILED|Screen init
580|INFO|ALLEGRO|Trying to init full-screen at 1920x1080.|Screen init
656|INFO|ALLEGRO|Successfully initialized full-screen with resolution 1920x1080 and color depth 32.|SUCCESS|Screen init

[stefanhendriks-felyx]

Hmm, well somehow it failed with that code. So I am unsure if it really worked.

One way to test this is to set the screen width/height to a resolution greater than the screen and see it fall back.

If that works, then I think we solved this part? (we still need to fix this DPI thing though).

[stefanhendriks-felyx]

I am not sure if this comment: #330 (comment) was using the same screen detection code, thats why I'm in doubt.

[stefanhendriks]

With #536 we've found another case. So this is not entirely fixed.