This repository has been archived by the owner on May 10, 2020. It is now read-only.
Add BigChar support and iterator for columns #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add BigChar decoder support * Add iter() to QueryRow to allow itterating over the columns * Export needed structs and enums to iterate over a column set without knowing it's types ahead of time
steffengy
suggested changes
Aug 30, 2018
| @@ -252,7 +256,7 @@ impl<I: BoxableIo> StmtResult<I> for ExecFuture<I> { | |||
|
|
|||
| /// A row in one resultset of a query | |||
| #[derive(Debug)] | |||
| pub struct QueryRow(TokenRow); | |||
| pub struct QueryRow(pub TokenRow); | |||
There was a problem hiding this comment.
This breaks BC and also I'd like this not exposed since it's protocol internals.
(e.g. in new TDS versions row might change)
| @@ -298,6 +299,11 @@ impl QueryRow { | |||
| let col_data = &self.0.columns[idx]; | |||
| R::from_column_data(col_data).map(Some) | |||
| } | |||
| pub fn iter( | |||
There was a problem hiding this comment.
This exposes MetaDataColumn, which is an implementation specific representation.
Same as above applies.
Exposing this should be done using a NewType wrapper instead that exposes methods for data that we'll want and won't change (e.g. name).
Also I think we should use a slice for that instead of an iterator (similar to the postgres/mysql implementation).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without knowing it's types ahead of time