Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Horizon to support stellar-core v12 #1772

Closed
6 tasks done
ire-and-curses opened this issue Sep 23, 2019 · 1 comment · Fixed by #1811
Closed
6 tasks done

Update Horizon to support stellar-core v12 #1772

ire-and-curses opened this issue Sep 23, 2019 · 1 comment · Fixed by #1811
Assignees
@bartekn
Labels
horizon

Comments

@ire-and-curses
Copy link
Member

ire-and-curses commented Sep 23, 2019 •
edited

Before v12 vote:

  • Note deprecation of returned type in \operations and \payments source code
  • Update the XDR library in the monorepo with the v12 definition files from stellar-core
  • Update Horizon to map incoming new types to path_payment. Continue to accept old path_payment type
  • Update documentation for operation types - indicate that response may not match underlying operation, and mention both old and new operation names
  • Note deprecation in release notes. Schedule to start returning path_payment_strict_receive and path_payment_strict_send in type field in two releases time (Horizon 0.24)
  • Release

This is part of #1737.
@ire-and-curses ire-and-curses added this to the Horizon 0.22.0 milestone Sep 23, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
This was referenced Sep 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@bartekn bartekn self-assigned this Sep 24, 2019
@bartekn
Copy link
Contributor

bartekn commented Sep 24, 2019

In progress in: #1776

@rice2000 rice2000 mentioned this issue Oct 3, 2019
Closed
@bartekn bartekn mentioned this issue Oct 7, 2019
Merged
@ire-and-curses ire-and-curses removed this from the Horizon 0.23.0 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekn bartekn

Labels
horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Horizon protocol v12 stellar/go
2 participants
@bartekn @ire-and-curses