exp/client/horizon: support fee_stats and account offers #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
Mar 14, 2019
exp/clients/horizon/client.go
Outdated
|
|
||
| // AccountOffers returns information about offers made by an account on the SDEX | ||
| // See https://www.stellar.org/developers/horizon/reference/endpoints/offers-for-account.html | ||
| func (c *Client) AccountOffers(request OfferRequest) (offers hProtocol.OffersPage, err error) { |
There was a problem hiding this comment.
Can we change the name to Offers. I think we will add /offers endpoint in a future so this will be confusing and we have ForAccount field in OfferRequest anyway.
| "p80_accepted_fee": "1225", | ||
| "p90_accepted_fee": "1225", | ||
| "p95_accepted_fee": "1225", | ||
| "p99_accepted_fee": "8000" |
There was a problem hiding this comment.
Can you change this response to have a different value for each field? Currently, typos like p10 instead of p20 won't be caught.
| func (or OfferRequest) BuildUrl() (endpoint string, err error) { | ||
| endpoint = fmt.Sprintf( | ||
| "accounts/%s/offers", | ||
| or.ForAccount, |
There was a problem hiding this comment.
You should check if ForAccount is empty and error in such case (because /offers is not there yet).
There was a problem hiding this comment.
This is already checked in client.AccountOffers()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for getting fee_stats and getting offers made by an account from horizon.
This closes #954