services/horizon: Fix ledger capacity usage in fee stats #1386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In protocol version 11 that implemented CAP-0005 the number of operations is used as the indicator of ledger capacity.
/fee_stats
endpoint is incorrectly using transaction count for ledger capacity stats.Goal and scope
Rewrite a query that calculates ledger capacity usage to correctly report fee stats.
Summary of changes
The query that calculates ledger capacity in the last 5 ledgers has been rewritten. Because we don't have access to number of failed operations in
history_ledgers
table (#1385) we first run subquery that returns number of operations for ledgers in question along withmax_tx_set_size
for each ledger and then calculate the capacity in the parent query.Known limitations & issues
PR Structure
otherwise).
services/friendbot
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.