Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix ledger capacity usage in fee stats #1386

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 11, 2019

Summary

In protocol version 11 that implemented CAP-0005 the number of operations is used as the indicator of ledger capacity. /fee_stats endpoint is incorrectly using transaction count for ledger capacity stats.

Goal and scope

Rewrite a query that calculates ledger capacity usage to correctly report fee stats.

Summary of changes

The query that calculates ledger capacity in the last 5 ledgers has been rewritten. Because we don't have access to number of failed operations in history_ledgers table (#1385) we first run subquery that returns number of operations for ledgers in question along with max_tx_set_size for each ledger and then calculate the capacity in the parent query.

Known limitations & issues

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

@bartekn bartekn added this to the Horizon 0.19.0 milestone Jun 13, 2019
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartekn bartekn merged commit f570483 into master Jun 18, 2019
@bartekn bartekn deleted the fix-ledger-capacity-usage branch June 18, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants