Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon - db clear command truncates all tables #1416

Merged

Conversation

brianc-tbcasoft
Copy link
Contributor

@brianc-tbcasoft brianc-tbcasoft commented Jun 15, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Ingestion.ClearAll() truncates all tables instead of deleting by range.

Goal and scope

The goal is make db clear command operate as intended. Reference: #1371

Summary of changes

  • added missing TableNames const declarations
  • modified Ingestion.ClearAll() to truncate all tables
  • added Session.TruncateTables() utility method
  • modified TestClearAll() to test for all empty tables

Known limitations & issues

none

What shouldn't be reviewed

n/a

@brianc-tbcasoft brianc-tbcasoft force-pushed the horizon-clear-all-truncates-all-tables branch from 7f01720 to 885be76 Compare June 15, 2019 14:30
@brianc-tbcasoft brianc-tbcasoft force-pushed the horizon-clear-all-truncates-all-tables branch from 885be76 to a5c37c4 Compare June 15, 2019 14:32
@brianc-tbcasoft brianc-tbcasoft changed the title Horizon db-clear command truncates all tables services/horizon - db clear command truncates all tables Jun 15, 2019
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianc-tbcasoft
Copy link
Contributor Author

awesome. i've signed the agreement

@bartekn bartekn merged commit 009589b into stellar:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants