ed25519 key derivation #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
requested review from
nullstyle,
vogel,
jedmccaleb,
tomerweller,
nikhilsaraf,
MonsieurNicolas,
stanford-scs,
poliha and
zbyszkol
This was referenced Nov 9, 2017
nullstyle
approved these changes
Nov 10, 2017
|
Yeah, I don't the the name neither but could find anything better. |
|
why don't we call the package |
The problem with this name is that slip0010 describes methods for other curves and we only implement one. But let's consider this when moving this outside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
derivationpackage which provides functions for ed25519 key derivation as described in SLIP-0010 in Go. This is compatible with ed25519 key derivation used in hardware wallets (like Ledger, Trezor).Derivation path (
m/44'/148'/x') for Stellar has been initially agreed in stellar/stellar-protocol#61 and will become SEP soon (this PR will be updated with correct SEP number). EDIT: SEP is here: stellar/stellar-protocol#63This PR and SEP will allow generating hierarchical deterministic Stellar accounts from a single seed (which can be generated using mnemonic code, like in BIP-0039). This should improve key storage (hardware wallets and storing master seed as 12-24 words instead of long strkey-encoded strings) and moving keys between wallets and apps.
@stanford-scs you are probably the main person who should check it out.