Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: Apply deprecation on some operation types, updating them to the correct value #2134

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Jan 17, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update type name for operations: pathPaymentStrictReceive, manageSellOffer, and createPassiveSellOffer. Fixes #2132

Why

The used type doesn't match the operation type, we delayed this change up to 0.25.0 and we are doing it now.

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Jan 17, 2020
@abuiles abuiles changed the base branch from release-horizon-v0.25.0 to int64-string January 17, 2020 12:37
@abuiles abuiles changed the base branch from int64-string to release-horizon-v0.25.0 January 20, 2020 22:24
…TypeManageSellOffer, and OperationTypeCreatePassiveSellOffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants