Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal: Fix data race in root endpoint #2745

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jun 25, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fixes #2737
There is a data race in the root endpoint when the action accesses action.App.coreVersion and other properties from action.App. These properties are updated in the App.Tick() goroutine. This commit fixes the data race by wrapping these properties in a read write lock. Whenever the properties are updated the write lock is acquired. Similarly, whenever the properties are read the read lock is acquired.

@tamirms tamirms requested a review from a team June 25, 2020 09:36
@cla-bot cla-bot bot added the cla: yes label Jun 25, 2020
@tamirms tamirms merged commit 8a6476e into stellar:release-horizon-v1.5.0 Jun 25, 2020
@tamirms tamirms deleted the root-race branch June 25, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants