Add offer prices to trades and trade aggregations #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerweller
force-pushed
the
trades_price
branch
from
d901d90
to
82c17ed
Compare
tomerweller
force-pushed
the
trades_price
branch
from
965f735
to
75f71ce
Compare
nullstyle
suggested changes
Feb 13, 2018
| @@ -120,11 +135,15 @@ func TestTradeActions_Aggregation(t *testing.T) { | |||
|
|
|||
| dbQ := &Q{ht.HorizonSession()} | |||
| ass1, ass2, err := PopulateTestTrades(dbQ, start, numOfTrades, minute, 0) | |||
| ht.Require.NoError(err) | |||
| if !ht.Assert.NoError(err) { | |||
There was a problem hiding this comment.
If a failed assertion should abort a test run then use Require.NoError instead of assert.
|
|
||
| //add other trades as noise, to ensure asset filtering is working | ||
| _, _, err = PopulateTestTrades(dbQ, start, numOfTrades, minute, numOfTrades) | ||
| ht.Require.NoError(err) | ||
| if !ht.Assert.NoError(err) { |
| if orderPreserved { | ||
| baseAccountId, baseAmount, counterAccountId, counterAmount = | ||
| sellerAccountId, trade.AmountSold, buyerAccountId, trade.AmountBought | ||
| } else { | ||
| baseAccountId, baseAmount, counterAccountId, counterAmount = | ||
| buyerAccountId, trade.AmountBought, sellerAccountId, trade.AmountSold | ||
| baseAccountId, baseAmount, counterAccountId, counterAmount, price = |
There was a problem hiding this comment.
I think a 5 clause compound assignment is over doing it. Let's expand this into separate statements for readability's sake.
xdr/db.go
Outdated
| arr := pq.Int64Array{} | ||
| err := arr.Scan(src) | ||
| if err != nil || len(arr)!=2 { | ||
| return err |
There was a problem hiding this comment.
Err will be nil here if len(arr)!=2
Please expand into two separate statements:
if err != nil {
return err
}
if len(arr) != 2 {
return errors.New("bzzzt")
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/tradesquery and response endpoint/trade_aggregationsto use trade offer pricescloses #224