Add data sponsoring integration test and fix Data effects #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not parsing data effects properly (even if they were already being emitted) due to missing Data effect `struct`s. That lead us to think we didn't have to add Data Sponsorship effects (for consistency). This commit adds: 1. An integration test for Data sponsorships 2. Effects for Data sponsorships 3. Data structures (and parsing) of Data effects.
This was referenced Sep 28, 2020
Closed
This was referenced Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not parsing data effects properly (even if they were already being emitted) due to missing Data effect
structs. That led us to think we didn't have to add Data Sponsorship effects (for consistency).This PR adds:
Part of #2939 , followup for #2951