Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix offers for account timestamps #480

Merged
merged 1 commit into from
Jun 5, 2018
Merged

fix offers for account timestamps #480

merged 1 commit into from
Jun 5, 2018

Conversation

tomerweller
Copy link
Contributor

Add a LedgerCache to OffersByAccountAction and populate the offer resource with ledger sequence number and closed_at time.

closes #478

nullstyle
nullstyle approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@nullstyle nullstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomerweller tomerweller merged commit 8e90266 into stellar:master Jun 5, 2018
@tomerweller tomerweller deleted the offers_fix_timestamp branch June 5, 2018 16:57
@bartekn bartekn mentioned this pull request Aug 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullstyle nullstyle nullstyle approved these changes

@bartekn bartekn Awaiting requested review from bartekn

@0xMichaelRan 0xMichaelRan Awaiting requested review from 0xMichaelRan

@nikhilsaraf nikhilsaraf Awaiting requested review from nikhilsaraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offer last_modified timestamps are wrong
2 participants
@tomerweller @nullstyle