Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'Processed ledger' log message conflict #5155

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 8, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

changed the 'Processed ledger' log output from streamLedger method to be a different and more precise phrase about transaction processors context to avoid conflict with an existing 'Processed ledger' log message that was already emitted from fsm.

Why

It allows determinstic log analysis when searching for 'Processed ledger' output.
Closes #5152

Known limitations

…dger to be different phrase to avoid conflict with existing 'Processed ledger' log output from fsm
@sreuland sreuland requested a review from a team January 8, 2024 20:25
@sreuland sreuland merged commit 495d18c into stellar:release-horizon-v2.28.0 Jan 8, 2024
28 checks passed
sreuland added a commit to sreuland/go that referenced this pull request Jan 29, 2024
…dger to be different phrase to avoid conflict with existing 'Processed ledger' log output from fsm (stellar#5155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants