Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest: Add more fine-grained reap metrics #5385

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jul 11, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add duration metrics for reaping of lookup tables where we can see how much time is spent reaping each table. See link below which displays the new metrics on staging:

https://grafana.stellar-ops.com/d/x8xDSQQIk/stellar-horizon?orgId=1&viewPanel=2531

Also, add metrics which count how many rows were deleted from each lookup table. See link below which displays the new metrics on staging:

https://grafana.stellar-ops.com/d/x8xDSQQIk/stellar-horizon?orgId=1&viewPanel=2541

Why

These fine-grained metrics are required so that we can analyze which tables are the most expensive to reap.

Known limitations

[N/A]

@tamirms tamirms marked this pull request as ready for review July 16, 2024 14:19
@tamirms tamirms requested a review from a team July 16, 2024 14:22
@tamirms tamirms merged commit 0e83215 into stellar:master Jul 16, 2024
23 checks passed
@tamirms tamirms deleted the reap-metrics branch July 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants