horizon: refactor and improve requestid package #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oryband
added a commit
to kinecosystem/go
that referenced
this pull request
Feb 20, 2019
…ate-to-stellar-head * stellar/master: (23 commits) Fix reference to non-existent bash variable add account streaming to the api doc (stellar#902) build: add Envelope method to tx builder (stellar#716) Use `routePattern` variable in `logEndOfRequest` (stellar#893) horizon: update changelog (stellar#888) horizon: refactor and improve requestid package (stellar#889) Fix name of `price` field on Trade (stellar#780) Fix case of `price` keys in example response (stellar#779) horizon.cmd: fix migration checks (stellar#886) horizon/cmd: point to current horizon repo changelog on migration cmd error (stellar#882) horizon: remove redundant return param from NewApp() (stellar#885) horizon/cmd: require at least one argument for rootCmd (stellar#879) horizon: consolidate middlewares (stellar#880) horizon: move cmd files into horizon/cmd (stellar#877) horizon/actions: have JSON() and Raw() return an error (stellar#873) horizon/actions: improve streaming error handling (stellar#856) travis: add gofmt and fix govet (stellar#865) horizon/actions: fix slice looping for offers in an account (stellar#837) Set default value when client data not present (stellar#860) Update Horizon 0.16.0 CHANGELOG with db migration notes (stellar#859) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestidpackage originally used typeintand value0as its context key, which may potentially collide with other context keys. This PR uses an unexported type for its context key.requestidpackage was ingo/support/context, but it ischispecific and only used by horizon. This PR moves it intohorizon/internal.main.gofor non-command line source. This PR renames the files tocontext.goandcontext_test.go.